Fix wrong asset 404 error #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salamandar
force-pushed
the
fix-wrong-asset-404-error
branch
from
99cecb7 to
547ee0e
Compare
fflorent
commented
Nov 4, 2024
Salamandar
force-pushed
the
fix-wrong-asset-404-error
branch
from
a34ffe1 to
b049157
Compare
|
@alexAubin it should be good imho but if you want to check it out before merging. |
alexAubin
approved these changes
Nov 4, 2024
|
@alexAubin @Salamandar So the plan is that we merge this PR and in case of regression we revert? I agree. FWIW: I don't have the rights to merge, I can't do that myself. |
|
Yeah, i'm just fixing some stuff that is already breaking the CI, then once i'm sure it works, let's merge this. |
|
Sounds wise, indeed! |
|
looks like it passes :) https://ci-apps.yunohost.org/ci/job/11118 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopen #176 with a fix to the issue @alexAubin mentioned here: #176 (comment)