New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Grist again as it uses non-/ `base` tag. #187

Merged

alexAubin merged 4 commits into YunoHost:master from orhtej2:unbnreak_grist_again

Nov 29, 2024

Contributor

orhtej2 commented Nov 28, 2024 •

edited

Loading

In #185 I broke previous fix for Grist from #176.
That's because Grist uses <base> tag and I disregarded it.

Tested with:

NocoDB (relative path to non-root in subdomain)
Grist (uses <base href="/some/location/"> tag)
Piped (uses <base href="/">)
Element (a standard app on subpath that uses relative linking)

orhtej2 added 4 commits

November 28, 2024 22:52


          Fixed Grist again as it uses non-/ base tag.

2ad6e11


          Added comments + simplified

be402af


          Fixed NocoDB and Grist

573f82a


          Fixed documentation.

alexAubin merged commit acfa333 into YunoHost:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet