refactor: resolve SonarAnalyzer S3776/S1541 complexity warnings - #259
Merged
Conversation
…eeView Locks current key-consumption semantics (vim navigation, gg/G sequence, global-shortcut bubble-up, non-vim/non-global base fallback) before the upcoming S1541 complexity refactor. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…Array/unsupported-extension branches Locks the Csv, JsonArray, and detection-failure branches before the upcoming S1541 complexity refactor of FileDialogHandler. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Split flagged high-complexity methods across 20 files into smaller helper methods; removed the corresponding grandfathered suppression blocks from .editorconfig. No behavioral changes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.editorconfigKeyPathTraverser(owned by Unbounded recursion in KeyPathTraverser can crash on deeply nested JSON #253) left untouchedMorphTableView/MorphTreeViewOnKeyDown,FileDialogHandler.HandleFileSelectedAsync) before refactoring those methodsTest plan
dotnet build— 0 warnings, 0 errorsdotnet format --verify-no-changes— no diffdotnet test— 1530/1530 passedCloses #258
🤖 Generated with Claude Code