fix: convert KeyPathTraverser recursion to iterative DFS - #263
Merged
Conversation
…write Adds depth-25 regression tests for key- and index-segment descent, plus a branching-index test pinning forward DFS order across nested array elements. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeyPathTraverser's mutual recursion with an explicit-stack iterative DFS, so traversal depth is bounded by the heap instead of the call stack.KeyPathTraverser(traversal entry point + iterative descent),KeyPathLeafCollector(leaf row collection / extraction / synthesis), andJsonByteExtractor(shared value-byte extraction primitive). Dependencies flow one-directionally:FullAggregationScanner → KeyPathTraverser → KeyPathLeafCollector, both depending onJsonByteExtractor.Closes #253
Test plan
dotnet formatcleandotnet build— 0 warnings / 0 errorsdotnet test— 1533/1533 passing (KeyPathTraverserTests21/21)