Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scorn support #123

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add Scorn support #123

wants to merge 5 commits into from

Conversation

revanmj
Copy link
Contributor

@revanmj revanmj commented Feb 7, 2024

No description provided.

@Z1ni
Copy link
Owner

Z1ni commented Jul 2, 2024

Thanks for the PR!

I'm liking the separate Scorn handling instead of adding the is_scorn argument to the 1c1f handler, as it's not really generic and reusable whereas the suffix argument is.

So if you can remove the b0a04d0 and 591005b commits (interactive rebase) and maybe also remove the unnecessary suffix argument from the scorn handler, I'll merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants