New feature: poll external file for console commands #1541
Conversation
|
I have changed the code to use FileReader/FileWriter classes, which use _wfopen if WIN32 is #defined. |
| if (i > 0 && i < (int)Args->NumArgs() - 1) | ||
| { | ||
| RefreshFile = Args->GetArgList(i + 1); | ||
| RefreshInterval = TICRATE; |
There was a problem hiding this comment.
When trying to merge this into QZDoom, I get the error that TICRATE isn't found.
There was a problem hiding this comment.
Confirmed, when doing this just on GZDoom, TICRATE isn't found. Please fix this.
There was a problem hiding this comment.
Which toolchain are you using? It builds fine on my machine with GCC 11.2.0.
I have just added an #include "doomdef.h" statement in c_console.cpp, it should fix the problem, TICRATE is defined as enum in this file. Please try to reproduce the issue by building 315e58f.
There was a problem hiding this comment.
I am using Visual Studio 2017. I'll try it again in a bit. If it works, then I'll put it in QZDoom.
The commit adds "-refreshfile" and "-refreshinterval" command-line arguments. Every refreshinterval tics (or once a second if not specified) a refreshfile is read and is evaluated if exists and not empty. Then it is truncated. This feature provides a facility for an external program to control the game.
|
I'm marking this one as "on hold" - I am not going to merge this one until I know for sure that it's okay to do so. |
|
This one needs an "ok" from Graf. Functionally it seems this was tested and I was going to go ahead and merge it, but considering the nature of this feature it will need that extra layer of approval. |
Yep, I agree. For what it's worth, I tested it more thoroughly than the others, and it performed flawlessly in all cases; I was actually rather impressed, as I even tried it with a few hundred lines, various refresh intervals, etc. That being said, I don't know this is the way to go about bringing in commands from outside; that is entirely up to Graf :) |
|
Hello everybody |
I'd like to see this resolved as well, the mod's been borked past GZDoom 4.10 as it lost the feature to read a constantly updating .txt file. |
|
I would also love to see this, the lack of an official IPC mechanism in GZDoom engenders some pretty gross workarounds. I was myself thinking along the lines of a socket-based protocol to send and receive netevents and netcommands without needing the whole netplay protocol, but the ability to send it console commands via file is not something I'd considered and would be a huge boon.
Is there something specific you're concerned about? The feature isn't active unless the user specifies it on the command line, AIUI, so it's not like it opens a running gzdoom to external nonsense by default. |
|
think @madame-rachelle talked about adding ipc to zscript before too? named pipes or smth, don't remember much off the top of my head |
The commit adds "-refreshfile" and "-refreshinterval" command-line
arguments. Every refreshinterval tics (or once a second if not
specified) a refreshfile is read and is evaluated if exists and not
empty. Then it is truncated.
This feature provides a facility for an external program to control
the game.