Update underscore prefix for image filenames #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@v2lmmj04 is attempting to deploy a commit to the zxy101's projects Team on Vercel. A member of the Team first needs to authorize it. |
This was an alternative I was thinking of initially since it better namespaces the files, but wasn't sure about. I saw this commit ended up going with this approach, so I'm aligning the PR to it in the end: KojoZero@6d550cb
v2lmmj04
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for this issue: #39
Media files that are prefixed by an underscore do not get checked by Anki's "Check Media" functionality. That means if an Anki note that has been created or updated via this reader gets deleted later on, Anki users must manually find + delete the image files that were referenced by the note.
This PR changes the underscore prefix on the image filename to allow for "Check Media" to work for detecting unused media files. The prefix added is "mokuro_*" to solve the Anki issue + reduce collision chance with random files from other sources, and aligns with the following commit on a fork for the same purpose:
KojoZero@6d550cb