Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include isort config in first_party detection #103

Closed
wants to merge 2 commits into from
Closed

Include isort config in first_party detection #103

wants to merge 2 commits into from

Conversation

SimonBiggs
Copy link

@SimonBiggs SimonBiggs commented Dec 24, 2023 •
edited
Loading

@jakkdl
Copy link
Contributor

jakkdl commented Dec 24, 2023

(that repo/issue is not publicly visible)

@SimonBiggs
Copy link
Author

SimonBiggs commented Dec 24, 2023 •
edited
Loading

Ahh, sure thankyou. Key issue was that shed does not obey the isort.cfg file and instead tries to determine the first party by itself. And the first party attempt isn't always reliable. So ideally at least an isort.cfg can be used in place of it.

This PR enables the use of an isort.cfg file to define known first party.

@Zac-HD
Copy link
Owner

Zac-HD commented Dec 27, 2023

I'm going to decline this, because we're aiming to move over to ruff instead soon - see e.g. #101. Will coordinate over on the other issue about that.

@Zac-HD Zac-HD closed this Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonBiggs @jakkdl @Zac-HD