Reorder Union/Literal subscripts to put None last #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
reviewed
May 2, 2022
tests/recorded/reorder_none.txt
Outdated
Comment on lines
13
to
17
| x: Union[ | ||
| int, | ||
| str, | ||
| None, | ||
| ] = 3 |
There was a problem hiding this comment.
I'm not a fan of how this splits out over multiple lines - can you make sure that the last subscript_slice does not have a comma? That way Black will keep it on one line, at least if it fits.
There was a problem hiding this comment.
Ah, I thought that this was something that Black just did by itself. I fixed this in the latest commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the third task (Reorder
UnionandLiteralcontents so thatNoneis last) in #22