Add transaction downloader and verifier

grafana/transaction_verification.json

@@ -0,0 +1,207 @@
+{
+    "__inputs": [
+        {
+            "name": "DS_PROMETHEUS-ZEBRA",
+            "label": "Prometheus-Zebra",
+            "description": "",
+            "type": "datasource",
+            "pluginId": "prometheus",
+            "pluginName": "Prometheus"
+        }
+    ],
+    "__requires": [
+        {
+            "type": "grafana",
+            "id": "grafana",
+            "name": "Grafana",
+            "version": "8.1.2"
+        },
+        {
+            "type": "panel",
+            "id": "graph",
+            "name": "Graph (old)",
+            "version": ""
+        },
+        {
+            "type": "datasource",
+            "id": "prometheus",
+            "name": "Prometheus",
+            "version": "1.0.0"
+        }
+    ],
+    "annotations": {
+        "list": [
+            {
+                "builtIn": 1,
+                "datasource": "-- Grafana --",
+                "enable": true,
+                "hide": true,
+                "iconColor": "rgba(0, 211, 255, 1)",
+                "name": "Annotations & Alerts",
+                "target": {
+                    "limit": 100,
+                    "matchAny": false,
+                    "tags": [],
+                    "type": "dashboard"
+                },
+                "type": "dashboard"
+            }
+        ]
+    },
+    "editable": true,
+    "gnetId": null,
+    "graphTooltip": 0,
+    "id": null,
+    "iteration": 1630092146360,
+    "links": [],
+    "panels": [
+        {
+            "aliasColors": {},
+            "bars": false,
+            "dashLength": 10,
+            "dashes": false,
+            "datasource": null,
+            "fill": 1,
+            "fillGradient": 0,
+            "gridPos": {
+                "h": 7,
+                "w": 24,
+                "x": 0,
+                "y": 0
+            },
+            "hiddenSeries": false,
+            "id": 6,
+            "legend": {
+                "avg": false,
+                "current": false,
+                "max": false,
+                "min": false,
+                "show": true,
+                "total": false,
+                "values": false
+            },
+            "lines": true,
+            "linewidth": 1,
+            "nullPointMode": "null",
+            "options": {
+                "alertThreshold": true
+            },
+            "percentage": false,
+            "pluginVersion": "8.1.2",
+            "pointradius": 2,
+            "points": false,
+            "renderer": "flot",
+            "repeatDirection": "h",
+            "seriesOverrides": [],
+            "spaceLength": 10,
+            "stack": false,
+            "steppedLine": false,
+            "targets": [
+                {
+                    "exemplar": true,
+                    "expr": "rate(gossip_downloaded_transaction_count{job=\"$job\"}[1m]) * 60",
+                    "interval": "",
+                    "legendFormat": "gossip_downloaded_transaction_count per min",
+                    "refId": "C"
+                },
+                {
+                    "exemplar": true,
+                    "expr": "rate(gossip_verified_transaction_count{job=\"$job\"}[1m]) * 60",
+                    "interval": "",
+                    "legendFormat": "gossip_verified_transaction_count per min",
+                    "refId": "D"
+                },
+                {
+                    "exemplar": true,
+                    "expr": "gossip_queued_transaction_count{job=\"$job\"}",
+                    "interval": "",
+                    "legendFormat": "gossip_queued_transaction_count",
+                    "refId": "E"
+                }
+            ],
+            "thresholds": [],
+            "timeFrom": null,
+            "timeRegions": [],
+            "timeShift": null,
+            "title": "Transaction Verifier Gossip Count - $job",
+            "tooltip": {
+                "shared": true,
+                "sort": 0,
+                "value_type": "individual"
+            },
+            "type": "graph",
+            "xaxis": {
+                "buckets": null,
+                "mode": "time",
+                "name": null,
+                "show": true,
+                "values": []
+            },
+            "yaxes": [
+                {
+                    "format": "short",
+                    "label": null,
+                    "logBase": 1,
+                    "max": null,
+                    "min": null,
+                    "show": true
+                },
+                {
+                    "format": "short",
+                    "label": null,
+                    "logBase": 1,
+                    "max": null,
+                    "min": null,
+                    "show": true
+                }
+            ],
+            "yaxis": {
+                "align": false,
+                "alignLevel": null
+            }
+        }
+    ],
+    "refresh": "5s",
+    "schemaVersion": 30,
+    "style": "dark",
+    "tags": [],
+    "templating": {
+        "list": [
+            {
+                "allValue": null,
+                "current": {},
+                "datasource": "${DS_PROMETHEUS-ZEBRA}",
+                "definition": "label_values(zcash_chain_verified_block_height, job)",
+                "description": null,
+                "error": null,
+                "hide": 0,
+                "includeAll": true,
+                "label": null,
+                "multi": true,
+                "name": "job",
+                "options": [],
+                "query": {
+                    "query": "label_values(zcash_chain_verified_block_height, job)",
+                    "refId": "StandardVariableQuery"
+                },
+                "refresh": 1,
+                "regex": "",
+                "skipUrlSync": false,
+                "sort": 1,
+                "tagValuesQuery": "",
+                "tagsQuery": "",
+                "type": "query",
+                "useTags": false
+            }
+        ]
+    },
+    "time": {
+        "from": "now-30m",
+        "to": "now"
+    },
+    "timepicker": {},
+    "timezone": "",
+    "title": "transaction verification",
+    "uid": "oBEHvS4nz",
+    "version": 2
+}

zebra-chain/src/transaction.rs

@@ -376,7 +376,8 @@ impl Transaction {
         }
     }
 
-    /// Returns `true` if this transaction is a coinbase transaction.
+    /// Returns `true` if this transaction is a coinbase transaction,
+    /// that is, has a single input and it is a coinbase input.
     pub fn is_coinbase(&self) -> bool {
         self.inputs().len() == 1
             && matches!(

zebra-chain/src/transaction/unmined.rs

@@ -12,7 +12,7 @@
 //! unmined transactions. They can be used to handle transactions regardless of version,
 //! and get the [`WtxId`] or [`Hash`] when required.
 
-use std::sync::Arc;
+use std::{fmt, sync::Arc};
 
 #[cfg(any(test, feature = "proptest-impl"))]
 use proptest_derive::Arbitrary;
@@ -93,6 +93,15 @@ impl From<&WtxId> for UnminedTxId {
     }
 }
 
+impl fmt::Display for UnminedTxId {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        match self {
+            Legacy(hash) => hash.fmt(f),
+            Witnessed(id) => id.fmt(f),
+        }
+    }
+}
+
 impl UnminedTxId {
     /// Create a new `UnminedTxId` using a v1-v4 legacy transaction ID.
     ///

zebra-consensus/src/error.rs

@@ -41,6 +41,9 @@ pub enum TransactionError {
     #[error("coinbase transaction MUST NOT have the EnableSpendsOrchard flag set")]
     CoinbaseHasEnableSpendsOrchard,
 
+    #[error("coinbase inputs MUST NOT exist in mempool")]
+    CoinbaseInMempool,
+
     #[error("coinbase transaction failed subsidy validation")]
     Subsidy(#[from] SubsidyError),
 

zebra-consensus/src/lib.rs

@@ -47,7 +47,7 @@ mod config;
 mod parameters;
 mod primitives;
 mod script;
-mod transaction;
+pub mod transaction;
 
 pub mod chain;
 #[allow(missing_docs)]

zebra-consensus/src/transaction.rs

@@ -1,3 +1,5 @@
+//! Asynchronous verification of transactions.
+//!
 use std::{
     collections::HashMap,
     future::Future,
@@ -50,6 +52,7 @@ where
     ZS: Service<zs::Request, Response = zs::Response, Error = BoxError> + Send + Clone + 'static,
     ZS::Future: Send + 'static,
 {
+    /// Create a new transaction verifier.
     pub fn new(network: Network, script_verifier: script::Verifier<ZS>) -> Self {
         Self {
             network,
@@ -165,11 +168,6 @@ where
 
     // TODO: break up each chunk into its own method
     fn call(&mut self, req: Request) -> Self::Future {
-        if req.is_mempool() {
-            // XXX determine exactly which rules apply to mempool transactions
-            unimplemented!("Zebra does not yet have a mempool (#2309)");
-        }
-
         let script_verifier = self.script_verifier.clone();
         let network = self.network;
 
@@ -186,6 +184,9 @@ where
             if tx.is_coinbase() {
                 check::coinbase_tx_no_prevout_joinsplit_spend(&tx)?;
             }
+            if req.is_mempool() && tx.contains_coinbase_input() {
+                return Err(TransactionError::CoinbaseInMempool);
+            }
 
             // [Canopy onward]: `vpub_old` MUST be zero.
             // https://zips.z.cash/protocol/protocol.pdf#joinsplitdesc

zebrad/src/commands/start.rs

@@ -56,7 +56,7 @@ impl StartCmd {
 
         info!("initializing verifiers");
         // TODO: use the transaction verifier to verify mempool transactions (#2637, #2606)
-        let (chain_verifier, _tx_verifier) = zebra_consensus::chain::init(
+        let (chain_verifier, tx_verifier) = zebra_consensus::chain::init(
             config.consensus.clone(),
             config.network.network,
             state.clone(),
@@ -75,6 +75,7 @@ impl StartCmd {
                 setup_rx,
                 state.clone(),
                 chain_verifier.clone(),
+                tx_verifier.clone(),
             ));
 
         let (peer_set, address_book) =