change(consensus): Skip coinbase spend must be shielded check on Regtest #8725
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is not yet ready for review.
Coinbase outputs must be shielded when first spent on Mainnet and Testnet in zcashd, but not on Regtest when configured with a flag, we want to do the same in Zebra.
Closes #8478.
Solution
Tests
Updates existing tests for immature coinbase output spends failing validation in the transaction verifier and state utxo check.
Follow Up Work
Add a field to
testnet::Parameters
for configuring whether the coinbase maturity rule should be checked or ignored on Regtest.PR Author's Checklist
PR Reviewer's Checklist