Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(consensus): Skip coinbase spend must be shielded check on Regtest #8725

Closed
wants to merge 3 commits into from

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Jul 27, 2024

Motivation

This PR is not yet ready for review.

Coinbase outputs must be shielded when first spent on Mainnet and Testnet in zcashd, but not on Regtest when configured with a flag, we want to do the same in Zebra.

Closes #8478.

Solution

  • Skips coinbase output maturity check on Regtest

Tests

Updates existing tests for immature coinbase output spends failing validation in the transaction verifier and state utxo check.

Follow Up Work

Add a field to testnet::Parameters for configuring whether the coinbase maturity rule should be checked or ignored on Regtest.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@arya2 arya2 added A-consensus Area: Consensus rule updates C-testing Category: These are tests P-Low ❄️ labels Jul 27, 2024
@arya2 arya2 self-assigned this Jul 27, 2024
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Jul 27, 2024
@arya2 arya2 changed the title change(consensus): Allow immature coinbase spends on Regtest change(consensus): Skip coinbase must be shielded check on Regtest Jul 29, 2024
@arya2 arya2 changed the title change(consensus): Skip coinbase must be shielded check on Regtest change(consensus): Skip coinbase spend must be shielded check on Regtest Aug 21, 2024
@arya2 arya2 added do-not-merge Tells Mergify not to merge this PR and removed do-not-merge Tells Mergify not to merge this PR labels Aug 27, 2024
@arya2
Copy link
Contributor Author

arya2 commented Oct 9, 2024

This PR still needs some work and this isn't currently a priority.

@arya2 arya2 closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for coinbases to be spent to transparent outputs on regtest
1 participant