Get username from PR to use in google-readability-todo
#106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the recommendation for `google-readability-todo` by providing a proper name which would previously be `TODO(docker)` or `TODO(unknown)`. If for whatever reason, the name cannot be found, it will default to `TODO(your name here)`. Implements ZedThree#102 without the need for a new parameter.
bwrsandman
force-pushed
the
todo-username
branch
from
d6c0719
to
8292677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the recommendation for
google-readability-todoby providing a proper name which would previously beTODO(docker)orTODO(unknown).If for whatever reason, the name cannot be found, it will default to
TODO(your name here).Closes #102 without the need for a new parameter.
Note that I think using
envin subprocess also kill all env leaking into the call forsubprocess.run. Hopefully no one relies on that.