create counter app and fetch user list from dummyapi#3
Open
nixvigilia wants to merge 4 commits into
Open
Conversation
nixvigilia
commented
Sep 20, 2023



Author
|
Hi Sir,
There is a default third-party library included in Create React App
specifically reportWebVitals. I have not removed it.
Thank you
…On Mon, Sep 25, 2023 at 6:48 PM Chan D ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In counter-app/src/reportWebVitals.js
<#3 (comment)>
:
> +const reportWebVitals = onPerfEntry => {
+ if (onPerfEntry && onPerfEntry instanceof Function) {
+ import('web-vitals').then(({ getCLS, getFID, getFCP, getLCP, getTTFB }) => {
+ getCLS(onPerfEntry);
+ getFID(onPerfEntry);
+ getFCP(onPerfEntry);
+ getLCP(onPerfEntry);
+ getTTFB(onPerfEntry);
+ });
+ }
+};
+
+export default reportWebVitals;
@nixvigilia <https://github.com/nixvigilia> May I know why is this added?
—
Reply to this email directly, view it on GitHub
<#3 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIG7EYNIYEF6CDZ4NPIP3YDX4FOQTANCNFSM6AAAAAA5AJEWBM>
.
You are receiving this because you were mentioned.Message ID:
<Zenith-Legion-Interactive/react-developer-test/pull/3/review/1641860655@
github.com>
|
Member
|
@nixvigilia I have another task for you to complement this assessment. |
Author
|
Hi @ProteanDev ,
Got it, will check.
Thank you!
…On Tue, Sep 26, 2023 at 11:56 AM Chan D ***@***.***> wrote:
@nixvigilia <https://github.com/nixvigilia> I have another task for you
to complement this assessment.
Kindly check the other PRs on this repo, see if you can improve yours
better than what they submitted.
Good luck.
—
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIG7EYIEM7X5DI4BRACUWJDX4JG6ZANCNFSM6AAAAAA5AJEWBM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Author
|
Hi @ProteanDev, |
Author
|
hi @ProteanDev, kindly disregard my previous message above. This branch has been updated for your review and approval, please. Thank you! |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



