Some fixes to !cases #431
Closed
Some fixes to !cases #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
metal0
force-pushed
the
fix-member-cases
branch
from
14b8420 to
bb4fdf6
Compare
almeidx
requested changes
Dec 28, 2023
| const title = `Most recent cases ${firstCaseNum}-${lastCaseNum} of ${totalCases} by ${modName}`; | ||
|
|
||
| const embed = { | ||
| author: { | ||
| name: title, | ||
| icon_url: mod instanceof User ? mod.displayAvatarURL() : undefined, | ||
| }, | ||
| description: lines.join("\n"), |
There was a problem hiding this comment.
We should make sure this is below 4096 characters
There was a problem hiding this comment.
That would require some major refactoring of the createPaginatedMessage since it's stateless and we just get a fixed # of cases per page currently, would have to offset the next page by X without being able to save this state anywhere.
Probably just lower cases per page, or implement ZDEV-62
| name: title, | ||
| icon_url: user instanceof User ? user.displayAvatarURL() : undefined, | ||
| }, | ||
| description: lines.join("\n"), |
Signed-off-by: GitHub <[email protected]>
|
Continued in #454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves:
lastCaseNumusing page boundary limits on last page rather than total casesFixes ZDEV-45, ZDEV-46