Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type safety: implement enums #1425

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Ovifer13
Copy link
Contributor

@Ovifer13 Ovifer13 commented Apr 4, 2023

Description

Relates to issue: ZEUS-1262

Implement an enum file where all enum variables are stored and can be used in all components.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • Core Lightning (Spark)
  • Eclair
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis requested a review from shubhamkmr04 April 4, 2023 20:47
@kaloudis kaloudis added this to the v0.7.5 milestone Apr 8, 2023
views/Order.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Channel listing view is breaking. Need to fix that.
In ChannelItem.tsx and Tag.tsx, We are importing Status from ChannelsPane.tsx that we have removed from there; it should be imported from enums,

Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to resolve branch conflicts as well.

shubhamkmr04

This comment was marked as duplicate.

@Ovifer13 Ovifer13 force-pushed the or/issue-1262/type-safety-implement-enums branch from 389e385 to 8e7e1fa Compare May 11, 2023 18:47
@@ -0,0 +1,188 @@
#!/usr/bin/env sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove this file @Ovifer13?

@kaloudis kaloudis removed this from the v0.7.5 milestone Dec 26, 2023
@kaloudis kaloudis force-pushed the master branch 6 times, most recently from 1c682d4 to 2068ca3 Compare November 2, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants