improved UX and error handling for wallet configuration #2594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myxmaster
force-pushed
the
improved_error_handling_in_wallet_config
branch
from
597f80e to
e0bf598
Compare
kaloudis
requested changes
Dec 19, 2024
| onChangeText={(text: string) => | ||
| onChangeText={(text: string) => { | ||
| const validHostChars = | ||
| /^[a-zA-Z0-9-.:]+$/; |
There was a problem hiding this comment.
this is incorrect. this doesn't allow you to input forward slashes, so you can't even specify https VS http
We should break this off into a utility func with accompanying tests
kaloudis
reviewed
Dec 19, 2024
| onBlur={() => { | ||
| if ( | ||
| customMailboxServer && | ||
| !/^[a-zA-Z0-9-.]+(:\d+)?$/.test( |
kaloudis
reviewed
Dec 19, 2024
|
|
||
| const cleanedText = | ||
| text.replace( | ||
| /[^a-zA-Z0-9-.:]/g, |
There was a problem hiding this comment.
any func w regex needs to be broken into a utility func and tests added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #2172 (all of it, so issue=PR description).
Additionally fixed
onFocusand addedonBlurforTextInputcomponent.This pull request is categorized as a:
Checklist
yarn run tscand made sure my code compiles correctlyyarn run lintand made sure my code didn’t contain any problematic patternsyarn run prettierand made sure my code is formatted correctlyyarn run testand made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarnafter this PR is merged inpackage.jsonandyarn.lockhave been properly updatedOther: