-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several layout improvements #2606
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b2c8d13
to
b49e5ea
Compare
b49e5ea
to
975a5c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, fixed in views/Settings/LightningAddress/index.tsx by wrapping "@zeuspay.com" text in a (Additionally removed nested View structures.) |
975a5c5
to
34ad548
Compare
Description
There is still work to do after this PR, but this is a step towards more consistent and cleaner layouting.
General:
Same overall padding/margin for Invoice, Payment, Privacy and Lightning Address Settings
Payment Settings/Invoices Settings/Privacy Settings/Lightning Address Settings/Receive:
-> switch cannot be pushed out of display view or overlap with text anymore
-> switch is now correctly centered vertically in case text has more than 1 line
<Row>
component in<Text>
component to not break layout if explainer is usedAdditionally:
Lightning - Default Fee Limit
: "sats" now has more space to the rightthemeColor('secondaryText')
to align with other font colors in SettingsBefore:
After:
-> This fixes #2546.
This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: