Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flake8] app.py #99

Merged
merged 1 commit into from
Mar 26, 2024
Merged

[flake8] app.py #99

merged 1 commit into from
Mar 26, 2024

Conversation

Lewis-Lu
Copy link
Contributor

@Lewis-Lu Lewis-Lu commented Mar 25, 2024

  1. make code style align to flake8
  2. avoid Bare except in Line 23.

Let me start this as the first contribution to the project. I'm adding a new feature to the tool.

@ZhangGe6 ZhangGe6 merged commit a4e2438 into ZhangGe6:master Mar 26, 2024
@ZhangGe6
Copy link
Owner

Merged. Thanks for your contribution and looking forward to the "new feature". BTW, can you introduce the new feature briefly?

@Lewis-Lu Lewis-Lu deleted the lewis_dev branch March 26, 2024 14:25
@Lewis-Lu
Copy link
Contributor Author

I don't know if it works, but the following is what I'm doing for the tool:

  1. study and fix the bug encountered during the delete&add ops ;
  2. add two graphs merge features.
  3. some customized operations, sounds weird, initializer/input conversion, for my own purpose;

@ZhangGe6
Copy link
Owner

study and fix the bug encountered during the delete&add ops ;

Bugs are indeed old friends of onnx-modifier. If you feel weird about the codes or behaviors, feel free to create issues.

add two graphs merge features.

Excellent! This is exactly what issue#63 calls for.

some customized operations, sounds weird, initializer/input conversion, for my own purpose;

It is welcome to share these features. Of course you can keep it in the local branch.

@Lewis-Lu
Copy link
Contributor Author

study and fix the bug encountered during the delete&add ops ;

Bugs are indeed old friends of onnx-modifier. If you feel weird about the codes or behaviors, feel free to create issues.

Sure, I would provide the steps for reproduce, and hopefully the PR for this in this week. :D

add two graphs merge features.

Excellent! This is exactly what issue#63 calls for.

some customized operations, sounds weird, initializer/input conversion, for my own purpose;

It is welcome to share these features. Of course you can keep it in the local branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants