[fix] optimize welcome message send timing

ZhgChgLi · Oct 4, 2022 · 5fcdece · 5fcdece
1 parent b28ee58
commit 5fcdece
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 12 deletions.
diff --git a/.version b/.version
@@ -1 +1 @@
-1.3.3
+1.3.4
diff --git a/lib/AndroidFetcher.rb b/lib/AndroidFetcher.rb
@@ -132,13 +132,13 @@ def execute()
 
             puts "[AndroidFetcher] latest review: #{reviews.last.body}, #{reviews.last.createdDateTimestamp}"
             setPlatformLatestCheckTimestamp(reviews.last.createdDateTimestamp)
+        end
 
-            # init first time, send welcome message
-            if latestCheckTimestamp == 0 
-                sendWelcomMessage()
-                return
-            end
 
+        # init first time, send welcome message
+        if latestCheckTimestamp == 0 
+            sendWelcomMessage()
+        elsif reviews.length > 0
             processReviews(reviews, platform)
         end
     end

diff --git a/lib/AppleFetcher.rb b/lib/AppleFetcher.rb
@@ -35,13 +35,12 @@ def execute()
 
             puts "[AppleFetcher] latest review: #{reviews.last.body}, #{reviews.last.createdDateTimestamp}"
             setPlatformLatestCheckTimestamp(reviews.last.createdDateTimestamp)
+        end
 
-            # init first time, send welcome message
-            if latestCheckTimestamp == 0 
-                sendWelcomMessage()
-                return;
-            end
-
+        # init first time, send welcome message
+        if latestCheckTimestamp == 0 
+            sendWelcomMessage()
+        elsif reviews.length > 0
             reviews = fullfillAppInfo(reviews)
             processReviews(reviews, platform)
         end