refactor(log): address too-many-statements, too-many-branches, and too-many-instance-attributes#42
Open
Jeudess wants to merge 42 commits into
Open
refactor(log): address too-many-statements, too-many-branches, and too-many-instance-attributes#42Jeudess wants to merge 42 commits into
Jeudess wants to merge 42 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change necessary?
The log_conditional implementation contained multiple code smells, including too-many-statements, too-many-branches, and too-many-instance-attributes. These issues made the code harder to read, understand, and maintain. This refactoring reorganizes the implementation to improve readability and maintainability while preserving the original behavior.
How was this tested?
The project's existing test suite was executed, and all tests passed after the refactoring.
Notes for the reviewer
This refactoring mainly reorganizes the internal implementation by extracting helper methods and improving the class structure. No functional behavior was changed, and the goal was solely to improve code quality and maintainability.