Basic test suite and a bunch of fixes

Fixes #45 (compatibility with KO 3.4.2), Fixes #46 (forget to unwatch
objects), Fixes #47 (bad parents in notification after object swap),
Fixes #48 (basic test suite). Updated dev dependencies, add
license/version banner to dist files.

Gruntfile.js

@@ -8,7 +8,7 @@ module.exports = function(grunt) {
     var banner = [
       "<%= pkg.name %> v<%= pkg.version %>",
       "The MIT License (MIT)",
-      "Copyright (c) 2016 <%= pkg.author %>"
+      "Copyright (c) 2017 <%= pkg.author %>",
     ].join("\n * ").trim();
 
     grunt.initConfig({
@@ -17,7 +17,7 @@ module.exports = function(grunt) {
 
         concat: {
             options: {
-                //banner: "/*! " + banner + " */\n\n"
+                banner: "/*! " + banner + " */\n"
             },
             copy: {
                 files: {
@@ -32,9 +32,10 @@ module.exports = function(grunt) {
 
         uglify: {
             options: {
-                //banner: "/*! " + banner + " */\n",
                 footer: "window.foo = \"<%= pkg.version %>\";",
-                preserveComments: 'some'
+                output: {
+                    comments: '/^!/'
+                }
             },
             main: {
                 files: {
@@ -48,13 +49,26 @@ module.exports = function(grunt) {
                 files: 'src/*.js',
                 tasks: ['jshint', 'uglify']
             }
+        },
+
+        jasmine: {
+            main: {
+                src: 'src/**/*.js',
+                options: {
+                    specs: 'spec/*.js',
+                    vendor: [
+                      'https://cdnjs.cloudflare.com/ajax/libs/knockout/3.4.2/knockout-min.js'
+                    ]
+                }
+            }
         }
     });
 
     grunt.loadNpmTasks('grunt-contrib-concat');
     grunt.loadNpmTasks('grunt-contrib-jshint');
     grunt.loadNpmTasks('grunt-contrib-uglify');
     grunt.loadNpmTasks('grunt-contrib-watch');
+    grunt.loadNpmTasks('grunt-contrib-jasmine');
 
     grunt.registerTask('default', ['concat', 'uglify']);
     grunt.registerTask('develop', ['concat', 'uglify', 'watch']);

README.md

@@ -133,6 +133,18 @@ Pausing and resuming a reactor on any property can be done like so:
     //...do work
     this.data.watch(true);
 
+<b>Dispose/Unwatch:</b><br/>
+The ```watch``` function returns an object with a "dispose" method you can call to dispose the watch action:
+
+    var viewModel = { ... };
+    var res = ko.watch(viewModel, { depth: -1 }, function(parents, child, item) {
+        ...
+    });
+
+    res.dispose();
+
+Once disposed your model will be "unwatched"<br/>
+
 <b>Projects using KO-Reactor:</b><br/>
 As of now I'm only aware of this excellent undo manager by Stefano Bagnara:
 
@@ -159,3 +171,22 @@ Yet another usage not mentioned above example involves calling ```watch``` on a
 However it is nothing more than a cosmetic enhancement since it only returns a ```computed``` of the function being passed in.
 
 For an extensive list of available options please consult the ```param``` sections of the source code.
+
+Development
+===========
+
+In order to build and minify you can simply call grunt:
+
+    grunt
+
+If you want a live rebuild for each changed
+
+    grunt develop
+
+If you want to run the test suite:
+
+    grunt jasmine
+
+If you want to generate the test runner in order to run the test suite in your browser
+
+    grunt jasmine:main:build

bower.json

@@ -3,7 +3,8 @@
   "homepage": "https://github.com/ZiadJ/knockoutjs-reactor.git",
   "authors": [
     "Ziad Jeeroburkhan",
-    "Jacob Kelley <[email protected]>"
+    "Jacob Kelley <[email protected]>",
+    "Stefano Bagnara <[email protected]>"
   ],
   "description": "Deeply watches observable changes",
   "main": [

dist/ko-reactor.js

@@ -1,3 +1,6 @@
+/*! ko-reactor v1.4.0-beta
+ * The MIT License (MIT)
+ * Copyright (c) 2017 Ziad Jeeroburkhan */
 // Deep observer plugin for Knockout http://knockoutjs.com/
 // (c) Ziad Jeeroburkhan
 // License: MIT (http://www.opensource.org/licenses/mit-license.php)
@@ -209,7 +212,7 @@ ko['watch'] = function (target, options, evaluatorCallback, context) {
         case "3.3.0": subscriptionsField = 'G'; break;
         case "3.4.0": subscriptionsField = 'K'; break;
         case "3.4.1": subscriptionsField = 'K'; break;
-        case "3.4.2": subscriptionsField = 'K'; break;
+        case "3.4.2": subscriptionsField = 'F'; break;
         default: throw "Unsupported Knockout version. Only v3.0.0 to v3.4.2 are supported when minified. Current version is " + ko.version;
     }
 
@@ -248,9 +251,8 @@ ko['watch'] = function (target, options, evaluatorCallback, context) {
 
                     if (!item.moved) {
                         // Deleted or brand new item. Unwatch or watch it accordingly.
-                        setTimeout(function () {
-                            watchChildren(item.value, (keepOffParentList ? null : child), parents, item.status === 'deleted');
-                        }, 0);
+                        // This used to be on a setTimeout but this is not symmetric to the !array case.
+                        watchChildren(item.value, (keepOffParentList ? null : child), parents, item.status === 'deleted');
                     }
                 });
             }, undefined, 'arrayChange')._watcher = context;
@@ -265,7 +267,7 @@ ko['watch'] = function (target, options, evaluatorCallback, context) {
 
                     if (options.mutable && typeof child() === 'object')
                         // Watch the new comer.
-                        watchChildren(child(), (keepOffParentList ? null : child), parents);
+                        watchChildren(child(), (keepOffParentList ? null : child), parents, false, true);
                 }
 
             }, null, 'change')._watcher = context;
@@ -286,7 +288,7 @@ ko['watch'] = function (target, options, evaluatorCallback, context) {
 
                     if (options.mutable && typeof oldValue === 'object')
                         // Clean up all subscriptions for the old child object.
-                        watchChildren(oldValue, (keepOffParentList ? null : child), parents, false, true);
+                        watchChildren(oldValue, (keepOffParentList ? null : child), parents, true, true);
 
                 }, null, 'beforeChange')._watcher = context;
             }

package.json

@@ -1,7 +1,7 @@
 {
   "name": "ko-reactor",
   "author": "Ziad Jeeroburkhan",
-  "version": "1.3.9",
+  "version": "1.4.0-beta",
   "repository": {
     "type": "git",
     "url": "https://github.com/ZiadJ/knockoutjs-reactor.git"
@@ -13,11 +13,12 @@
   },
   "devDependencies": {
     "bower": "*",
-    "grunt": "~0.4.1",
-    "grunt-cli": "~0.1.9",
-    "grunt-contrib-concat": "^0.5.0",
-    "grunt-contrib-jshint": "0.8.0",
-    "grunt-contrib-uglify": "0.2.5",
-    "grunt-contrib-watch": "~0.5.3"
+    "grunt": "~1.0.1",
+    "grunt-cli": "~1.2.0",
+    "grunt-contrib-concat": "~1.0.1",
+    "grunt-contrib-jasmine": "~1.1.0",
+    "grunt-contrib-jshint": "~1.1.0",
+    "grunt-contrib-uglify": "~3.1.0",
+    "grunt-contrib-watch": "~1.0.0"
   }
 }