Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont use cache.ttl, but use entrust.cache_ttl instead #735

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nemoden
Copy link

@Nemoden Nemoden commented Feb 8, 2017

I've set up caching for my laravel application and it suddenly failed to run due to "Unsupported operand types" which was confusing and misleading because the only thing I've done setting cache.ttl:

'ttl' => [
    'products' => 10, # cache products for 10 minutes
    'listings' => 20, # cache listings for 20 minutes
];

in config/cache.php

I actually was surprised that Entrust uses cache.ttl which it really shouldn't.
config/cache.php is a good place to store USER-DEFINED cache settings like mine cache.ttl.products,

3rd parties should use own configuration to not interfere with user settings.
It wasn't nice that Entrust has occupied certain namespace in my domain that I control.

I propose store cache ttl for Entrust in entrust.cache_ttl (it's more explicit also).

@Nemoden Nemoden changed the title Dont use cache.ttl due to unexpected behavior Dont use cache.ttl, but use entrust.cache_ttl instead Feb 8, 2017
@franzdumfart
Copy link

Any news about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants