Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use laravel cache key (to allow multiple apps to use the same caching server) #835

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LeNiglo
Copy link

@LeNiglo LeNiglo commented Sep 1, 2017

These commits fixes the key stored in the cache to match laravel conventions.
This is important when you have multiple Laravel apps using the same caching server, because they override one another.

It now respects laravel cache key convention.
It now respects laravel cache key convention.
@LeNiglo
Copy link
Author

LeNiglo commented Sep 1, 2017

Looks like I can't use a key from Laravel itself ?
Agreed that tests will fail, but is possible to make it work on a working environment ?

@Zizaco
Copy link
Owner

Zizaco commented Nov 13, 2017

I understand the issue... I'm going to work on a fix and in updating the tests to match the fix

@Zizaco Zizaco changed the title Fixed caching key Use laravel cache key (to allow multiple apps to use the same caching server) Nov 13, 2017
@LeNiglo
Copy link
Author

LeNiglo commented Nov 14, 2017

That's great, thank you @Zizaco 😄

@LeNiglo
Copy link
Author

LeNiglo commented Jan 7, 2019

Any updates on this one ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants