Major version to work with Laravel 6 #958
Open
+1,152
−592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When will you merge and release this? |
|
Still waiting on this and can't move to laravel 6 without it. If we need to start looking out people to help out with management of this repo i am more than happy to help |
pirupius
reviewed
Jan 17, 2020
|
|
||
| matrix: | ||
| fast_finish: true | ||
| allow_failures: | ||
| - php: 7.0 | ||
| - php: 7.3 |
Comment on lines
-518
to
-528
| If you encounter an error when doing the migration that looks like: | ||
|
|
||
| ``` | ||
| SQLSTATE[HY000]: General error: 1005 Can't create table 'laravelbootstrapstarter.#sql-42c_f8' (errno: 150) | ||
| (SQL: alter table `role_user` add constraint role_user_user_id_foreign foreign key (`user_id`) | ||
| references `users` (`id`)) (Bindings: array ()) | ||
| ``` | ||
|
|
||
| Then it's likely that the `id` column in your user table does not match the `user_id` column in `role_user`. | ||
| Make sure both are `INT(10)`. | ||
|
|
There was a problem hiding this comment.
Some of these changes to the readme file aren't necessary like removing of this and model namespacing.
| @@ -162,7 +163,7 @@ public function can($permission, $requireAll = false) | |||
| foreach ($this->cachedRoles() as $role) { | |||
| // Validate against the Permission table | |||
| foreach ($role->cachedPermissions() as $perm) { | |||
| if (str_is( $permission, $perm->name) ) { | |||
| if (Str::is( $permission, $perm->name) ) { | |||
|
Guys, it's a dead package. Use laravel-roles instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated all dependencies, migrations template and whole package in general in order to work with Laravel >=6 version.