Open
Conversation
Refactor for better typing, structure, and readability: - Added type hints for methods and parameters - Split complex methods into smaller, focused helpers - Used null coalescing (??) and strict comparison (===) - Refactored conditionals using match in formatAbilityResult() - Improved method naming to avoid trait conflicts - Removed unnecessary returns in void methods - Added return types for clarity and safety - Reduced duplication in role/ability checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Improvements
??for cleaner default handlingmatchexpression===) for better reliabilityboot→bootEntrustUserTrait) to prevent conflictsreturnstatements from void methodsThese changes improve readability, maintainability, and type safety without altering the original behavior.