Closed
Conversation
use contains_key instead of get().is_some() implement Display instead of ToString for G2AFFINE don't use enumerate when index is dropped replace legacy function isize::max_value with isize::Max
JsValue::from_serde and JsValue::into_serde are deprecated use serde-wasm-bindgen instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to an ABI mismatch between clang and rust, wasm-bindgen older then 2.88 will become incompatible with the rust compiler at some point. See rust-lang/rust#63649 and rust-lang/rust#71871 .
In later versions of wasm-bindgen
JsValue::from_serdeandJsValue::into_serdeare deprecated and usingserde-wasm-bindgenis suggested instead. See wasm-bindgen/wasm-bindgen#3031 .This pr also fixes the following clippy issues: