Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring + repo structure #66

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Refactoring + repo structure #66

wants to merge 6 commits into from

Conversation

jleni
Copy link
Member

@jleni jleni commented Sep 1, 2024 •
edited
Loading

  • Improve repo structure (GitHub actions, obsolete files, etc.)
  • Upgrade dependencies + move to noble libs

emmanuelm41
emmanuelm41 approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@emmanuelm41 emmanuelm41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments

package.json
"bugs": {
"url": "https://github.com/cosmos/ledger-cosmos-js/issues"
"url": "https://github.com/Zondax/ledger-cosmos-js/issues"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? issues on our repo, but te repository points to cosmos repo

package.json
"@zondax/ledger-js": "^0.10.0",
"bech32": "^2.0.0",
"@ledgerhq/hw-transport": "6.31.2",
"@noble/hashes": "^1.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure this is browser compatible? We are changing from browserfy to this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelm41 emmanuelm41 emmanuelm41 approved these changes

@chcmedeiros chcmedeiros chcmedeiros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jleni @emmanuelm41 @chcmedeiros @KVNLS