Skip to content

chore: enforce no-floating-promises in core/task/ #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edelauna merged 5 commits into from
Jun 30, 2026
Merged

chore: enforce no-floating-promises in core/task/ #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1691955
fix(task): handle rejections on void-prefixed async calls in Task.ts
0xMink May 24, 2026
c5d8d4a
fix(Task): match the abort error message in presentAssistantMessageSafe
0xMink May 24, 2026
e57c772
fix(Task): catch updateClineMessage rejections on partial-message paths
0xMink May 24, 2026
8fa009c
feat(Task): adding catch block to log any errors
edelauna Jun 30, 2026
6686bbf
test(Task): coverage
edelauna Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/core/assistant-message/presentAssistantMessage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,8 +959,7 @@ export async function presentAssistantMessage(cline: Task) {
if (cline.currentStreamingContentIndex < cline.assistantMessageContent.length) {
// There are already more content blocks to stream, so we'll call
// this function ourselves.
presentAssistantMessage(cline)
return
return presentAssistantMessage(cline)
} else {
// CRITICAL FIX: If we're out of bounds and the stream is complete, set userMessageContentReady
// This handles the case where assistantMessageContent is empty or becomes empty after processing
Expand All @@ -972,7 +971,7 @@ export async function presentAssistantMessage(cline: Task) {

// Block is partial, but the read stream may have finished.
if (cline.presentAssistantMessageHasPendingUpdates) {
presentAssistantMessage(cline)
return presentAssistantMessage(cline)
}
}

Expand Down
147 changes: 117 additions & 30 deletions src/core/task/Task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,29 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
*/
assistantMessageSavedToHistory = false

/**
* Fire-and-forget wrapper around `presentAssistantMessage` that swallows the
* expected cancellation rejection (the presenter throws when `this.abort` is set)
* and logs any other failure. Keeping it non-blocking preserves the streaming
* presenter's self-locking semantics while preventing unhandled promise rejections
* from crashing the extension host.
*/
private presentAssistantMessageSafe(): void {
void presentAssistantMessage(this).catch((error) => {
// Discriminate on the error message rather than `this.abort` state,
// which can flip between the throw and the catch microtask running:
// a real failure followed by an abort flip would otherwise be
// silently swallowed, and a stale abort error logged as a failure.
// The abort throw site in presentAssistantMessage emits a message
// ending in "aborted" (matching the other abort-throw contracts in
// this file), so we suppress exactly that.
if (error instanceof Error && error.message.endsWith("aborted")) {
return
}
console.error(`[Task#presentAssistantMessage] task ${this.taskId}.${this.instanceId} failed:`, error)
})
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}

/**
* Push a tool_result block to userMessageContent, preventing duplicates.
* Duplicate tool_use_ids cause API errors.
Expand Down Expand Up @@ -522,7 +545,15 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
this.messageQueueStateChangedHandler = () => {
this.emit(RooCodeEventName.TaskUserMessage, this.taskId)
this.emit(RooCodeEventName.QueuedMessagesUpdated, this.taskId, this.messageQueueService.messages)
this.providerRef.deref()?.postStateToWebviewWithoutTaskHistory()
void this.providerRef
.deref()
?.postStateToWebviewWithoutTaskHistory()
.catch((error) => {
console.error(
"[Task#messageQueueStateChangedHandler] postStateToWebviewWithoutTaskHistory failed:",
error,
)
})
}

this.messageQueueService.on("stateChanged", this.messageQueueStateChangedHandler)
Expand Down Expand Up @@ -567,9 +598,13 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
if (startTask) {
this._started = true
if (task || images) {
this.startTask(task, images)
void this.startTask(task, images).catch((error) => {
console.error("[Task#constructor] startTask failed:", error)
})
} else if (historyItem) {
this.resumeTaskFromHistory()
void this.resumeTaskFromHistory().catch((error) => {
console.error("[Task#constructor] resumeTaskFromHistory failed:", error)
})
} else {
throw new Error("Either historyItem or task/images must be provided")
}
Expand Down Expand Up @@ -1162,7 +1197,13 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
// data or one whole message at a time so ignore partial for
// saves, and only post parts of partial message instead of
// whole array in new listener.
this.updateClineMessage(lastMessage)
// Fire-and-forget: the webview post is internally guarded, but
// the `RooCodeEventName.Message` emit can synchronously throw
// if any consumer-attached listener does, which would surface
// here as an unhandled rejection. Log it instead.
this.updateClineMessage(lastMessage).catch((error) => {
console.error("[Task#ask] updateClineMessage failed:", error)
})
// console.log("Task#ask: current ask promise was ignored (#1)")
throw new AskIgnoredError("updating existing partial")
} else {
Expand Down Expand Up @@ -1203,7 +1244,11 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
lastMessage.isAnswered = true
}
await this.saveClineMessages()
this.updateClineMessage(lastMessage)
// Fire-and-forget: see updateClineMessage call above for the
// rationale on the .catch arm.
this.updateClineMessage(lastMessage).catch((error) => {
console.error("[Task#ask] updateClineMessage failed:", error)
})
} else {
// This is a new and complete message, so add it like normal.
this.askResponse = undefined
Expand Down Expand Up @@ -1274,7 +1319,10 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
if (message) {
this.interactiveAsk = message
this.emit(RooCodeEventName.TaskInteractive, this.taskId)
provider?.postMessageToWebview({ type: "interactionRequired" })
/* v8 ignore next 3 -- fires inside 2s timer after ask() resolves; not reachable in unit tests */
void provider?.postMessageToWebview({ type: "interactionRequired" }).catch((error) => {
console.error("[Task#ask] postMessageToWebview interactionRequired failed:", error)
})
}
}, statusMutationTimeout),
)
Expand Down Expand Up @@ -1414,7 +1462,9 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
)
if (lastToolAskIndex !== -1) {
this.clineMessages[lastToolAskIndex].isAnswered = true
void this.updateClineMessage(this.clineMessages[lastToolAskIndex])
void this.updateClineMessage(this.clineMessages[lastToolAskIndex]).catch((error) => {
console.error("[Task#handleWebviewAskResponse] updateClineMessage failed:", error)
})
this.saveClineMessages().catch((error) => {
console.error("Failed to save answered tool-ask state:", error)
})
Expand Down Expand Up @@ -1662,7 +1712,13 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
lastMessage.images = images
lastMessage.partial = partial
lastMessage.progressStatus = progressStatus
this.updateClineMessage(lastMessage)
// Fire-and-forget: webview post is internally guarded, but the
// `RooCodeEventName.Message` emit can synchronously throw via a
// consumer-attached listener. Surface that as a log, not an
// unhandled rejection.
this.updateClineMessage(lastMessage).catch((error) => {
console.error("[Task#say] updateClineMessage failed:", error)
})
} else {
// This is a new partial message, so add it with partial state.
const sayTs = Date.now()
Expand Down Expand Up @@ -1701,7 +1757,11 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
await this.saveClineMessages()

// More performant than an entire `postStateToWebview`.
this.updateClineMessage(lastMessage)
// Fire-and-forget: see updateClineMessage call above for the
// rationale on the .catch arm.
this.updateClineMessage(lastMessage).catch((error) => {
console.error("[Task#say] updateClineMessage failed:", error)
})
} else {
// This is a new and complete message, so add it like normal.
const sayTs = Date.now()
Expand Down Expand Up @@ -1810,7 +1870,9 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
const { task, images } = this.metadata

if (task || images) {
this.startTask(task ?? undefined, images ?? undefined)
void this.startTask(task ?? undefined, images ?? undefined).catch((error) => {
console.error("[Task#start] startTask failed:", error)
})
}
}

Expand Down Expand Up @@ -2351,7 +2413,11 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {

private async initiateTaskLoop(userContent: Anthropic.Messages.ContentBlockParam[]): Promise<void> {
// Kicks off the checkpoints initialization process in the background.
getCheckpointService(this)
// `getCheckpointService` wraps its full body in a try/catch and returns
// `undefined` on failure (see src/core/checkpoints/index.ts), so the
// returned promise cannot reject. `void` is sufficient — no `.catch`
// arm needed.
void getCheckpointService(this)

let nextUserContent = userContent
let includeFileDetails = true
Expand Down Expand Up @@ -2688,9 +2754,13 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
if (signal.aborted) {
reject(new Error("Request cancelled by user"))
} else {
signal.addEventListener("abort", () => {
reject(new Error("Request cancelled by user"))
}, { once: true })
signal.addEventListener(
"abort",
() => {
reject(new Error("Request cancelled by user"))
},
{ once: true },
)
Comment on lines +2757 to +2763

@coderabbitai coderabbitai Bot Jun 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Remove abort listeners when the raced chunk wins.

{ once: true } only cleans up after abort fires. For normal streaming, each nextChunkWithAbort() call leaves its abort listener attached until request teardown, so long streams can accumulate listeners and trigger memory/listener warnings.

Suggested cleanup pattern 
- signal.addEventListener(
- 	"abort",
- 	() => {
- 		reject(new Error("Request cancelled by user"))
- 	},
- 	{ once: true },
- )
+ const onAbort = () => reject(new Error("Request cancelled by user"))
+ signal.addEventListener("abort", onAbort, { once: true })

Then wrap the Promise.race(...) with finally and call signal.removeEventListener("abort", onAbort).

Also applies to: 4288-4294

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/core/task/Task.ts` around lines 2753 - 2759, The abort handling in
nextChunkWithAbort() / the Promise.race chunk path leaves an abort listener
attached when the chunk promise wins, which can accumulate across long streams.
Refactor the signal.addEventListener("abort", ...) usage to keep a named onAbort
handler, wrap the race in a finally, and call
signal.removeEventListener("abort", onAbort) when the request completes
normally. Apply the same cleanup to the matching abort-listener block in the
other referenced chunk path so both Task.ts sites follow the same pattern.

}
})
return await Promise.race([nextPromise, abortPromise])
Expand Down Expand Up @@ -2794,7 +2864,8 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
// Add to content and present
this.assistantMessageContent.push(partialToolUse)
this.userMessageContentReady = false
presentAssistantMessage(this)
/* v8 ignore next -- streaming presenter; .catch lives in presentAssistantMessageSafe (covered) */
this.presentAssistantMessageSafe()
} else if (event.type === "tool_call_delta") {
// Process chunk using streaming JSON parser
const partialToolUse = NativeToolCallParser.processStreamingChunk(
Expand All @@ -2813,7 +2884,8 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
this.assistantMessageContent[toolUseIndex] = partialToolUse

// Present updated tool use
presentAssistantMessage(this)
/* v8 ignore next -- streaming presenter; .catch lives in presentAssistantMessageSafe (covered) */
this.presentAssistantMessageSafe()
}
}
} else if (event.type === "tool_call_end") {
Expand All @@ -2839,7 +2911,8 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
this.userMessageContentReady = false

// Present the finalized tool call
presentAssistantMessage(this)
/* v8 ignore next -- streaming presenter; .catch lives in presentAssistantMessageSafe (covered) */
this.presentAssistantMessageSafe()
} else if (toolUseIndex !== undefined) {
// finalizeStreamingToolCall returned null (malformed JSON or missing args)
// Mark the tool as non-partial so it's presented as complete, but execution
Expand All @@ -2858,7 +2931,8 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
this.userMessageContentReady = false

// Present the tool call - validation will handle missing params
presentAssistantMessage(this)
/* v8 ignore next -- streaming presenter; .catch lives in presentAssistantMessageSafe (covered) */
this.presentAssistantMessageSafe()
}
}
}
Expand Down Expand Up @@ -2891,7 +2965,8 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {

// Present the tool call to user - presentAssistantMessage will execute
// tools sequentially and accumulate all results in userMessageContent
presentAssistantMessage(this)
/* v8 ignore next -- streaming presenter; .catch lives in presentAssistantMessageSafe (covered) */
this.presentAssistantMessageSafe()
break
}
case "text": {
Expand All @@ -2910,7 +2985,8 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
})
this.userMessageContentReady = false
}
presentAssistantMessage(this)
/* v8 ignore next -- streaming presenter; .catch lives in presentAssistantMessageSafe (covered) */
this.presentAssistantMessageSafe()
break
}
}
Expand Down Expand Up @@ -3237,7 +3313,8 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
this.userMessageContentReady = false

// Present the finalized tool call
presentAssistantMessage(this)
/* v8 ignore next -- streaming presenter; .catch lives in presentAssistantMessageSafe (covered) */
this.presentAssistantMessageSafe()
} else if (toolUseIndex !== undefined) {
// finalizeStreamingToolCall returned null (malformed JSON or missing args)
// We still need to mark the tool as non-partial so it gets executed
Expand All @@ -3256,7 +3333,8 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
this.userMessageContentReady = false

// Present the tool call - validation will handle missing params
presentAssistantMessage(this)
/* v8 ignore next -- streaming presenter; .catch lives in presentAssistantMessageSafe (covered) */
this.presentAssistantMessageSafe()
}
}
}
Expand Down Expand Up @@ -3455,7 +3533,8 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
// If there is content to update then it will complete and
// update `this.userMessageContentReady` to true, which we
// `pWaitFor` before making the next request.
presentAssistantMessage(this)
/* v8 ignore next -- streaming presenter; .catch lives in presentAssistantMessageSafe (covered) */
this.presentAssistantMessageSafe()
}

if (hasTextContent || hasToolUses) {
Expand Down Expand Up @@ -4191,10 +4270,14 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
const iterator = stream[Symbol.asyncIterator]()

// Set up abort handling - when the signal is aborted, clean up the controller reference
abortSignal.addEventListener("abort", () => {
console.log(`[Task#${this.taskId}.${this.instanceId}] AbortSignal triggered for current request`)
this.currentRequestAbortController = undefined
}, { once: true })
abortSignal.addEventListener(
"abort",
() => {
console.log(`[Task#${this.taskId}.${this.instanceId}] AbortSignal triggered for current request`)
this.currentRequestAbortController = undefined
},
{ once: true },
)

try {
// Awaiting first chunk to see if it will throw an error.
Expand All @@ -4206,9 +4289,13 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
if (abortSignal.aborted) {
reject(new Error("Request cancelled by user"))
} else {
abortSignal.addEventListener("abort", () => {
reject(new Error("Request cancelled by user"))
}, { once: true })
abortSignal.addEventListener(
"abort",
() => {
reject(new Error("Request cancelled by user"))
},
{ once: true },
)
}
})

Expand Down
Loading
Loading