ignore private properties in base entities...

also entities starting with underscore are ignored!

composer.json

@@ -45,7 +45,7 @@
     "phpstan/phpstan-phpunit": "^0.12",
     "nette/neon": "^3",
     "brick/date-time": "^0.3",
-    "zrnik/phpunit-exceptions": "^0.0.4"
+    "zrnik/phpunit-exceptions": "^0.0.5"
   },
   "autoload": {
     "psr-4": {

src/Repository/BaseEntity.php

@@ -131,6 +131,14 @@ public function toArray(): array
 
         foreach ($reflection->getProperties() as $reflectionProperty) {
 
+            if ($reflectionProperty->isPrivate()) {
+                continue;
+            }
+
+            if (str_starts_with($reflectionProperty->getName(), '_')) {
+                continue;
+            }
+
             if (!$reflectionProperty->isInitialized($this)) {
                 continue;
             }
@@ -287,6 +295,14 @@ public static function fromIterable(iterable $iterable): static
 
         foreach ($reflection->getProperties() as $reflectionProperty) {
 
+            if (str_starts_with($reflectionProperty->getName(), '_')) {
+                continue;
+            }
+
+            if ($reflectionProperty->isPrivate()) {
+                continue;
+            }
+
             $propertyName = $reflectionProperty->getName();
             $reflectionPropertyName = $reflectionProperty->getName();
             $intrinsicType = $reflectionProperty->getType();

tests/IntegrationTest.php

@@ -19,6 +19,8 @@
 use Tests\Mock\BaseRepositoryAndBaseEntity\Entities\Auction;
 use Tests\Mock\BaseRepositoryAndBaseEntity\Entities\AuctionItem;
 use Tests\Mock\BaseRepositoryAndBaseEntity\Entities\AutoHydrateAndCircularReference\ReferencingEntityOne;
+use Tests\Mock\BaseRepositoryAndBaseEntity\Entities\EntityWithPrivateProperty\EntityWithPrivateProperty;
+use Tests\Mock\BaseRepositoryAndBaseEntity\Entities\EntityWithPrivateProperty\PrivatePropertyRepository;
 use Tests\Mock\BaseRepositoryAndBaseEntity\Entities\NullableForeignKeyNoError\NullableForeignKeyNoErrorRepository;
 use Tests\Mock\BaseRepositoryAndBaseEntity\Entities\NullableForeignKeyNoError\SelfRepeating;
 use Tests\Mock\BaseRepositoryAndBaseEntity\Entities\NullableForeignKeyNoError\SubClass;
@@ -105,6 +107,7 @@ public function testIntegration(): void
      * @param PDO $pdo
      * @param string $version
      * @throws JsonException
+     * @throws Exception
      */
     private function processTest(PDO $pdo, string $version = ''): void
     {
@@ -193,6 +196,8 @@ function () use ($Updater) {
 
         $this->treeSavingFailed($pdo);
 
+        $this->subTestAllowPrivatePropertiesInEntities($pdo);
+
 
         echo ']' . PHP_EOL . 'Complete!';
 
@@ -1185,4 +1190,21 @@ private function treeSavingFailed(PDO $pdo): void
         static::assertSame($subNode1->id, (int)$saved[2]['parent']);
         static::assertSame($subNode2->id, (int)$saved[3]['parent']);
     }
+
+    private function subTestAllowPrivatePropertiesInEntities(PDO $pdo): void
+    {
+        $repo = new PrivatePropertyRepository($pdo);
+
+        /** @var EntityWithPrivateProperty $entity */
+        $entity = EntityWithPrivateProperty::create();
+        $entity->name = 'Hello World';
+
+        $repo->save($entity);
+
+        /** @var EntityWithPrivateProperty[] $entities */
+        $entities = $repo->getAll(EntityWithPrivateProperty::class);
+
+        static::assertSame($entities[count($entities) - 1]->id, $entity->id);
+
+    }
 }

tests/Mock/BaseRepositoryAndBaseEntity/Entities/EntityWithPrivateProperty/EntityWithPrivateProperty.php

@@ -0,0 +1,24 @@
+<?php declare(strict_types=1);
+
+namespace Tests\Mock\BaseRepositoryAndBaseEntity\Entities\EntityWithPrivateProperty;
+
+use Zrnik\MkSQL\Repository\Attributes\ColumnType;
+use Zrnik\MkSQL\Repository\Attributes\PrimaryKey;
+use Zrnik\MkSQL\Repository\Attributes\TableName;
+use Zrnik\MkSQL\Repository\BaseEntity;
+
+#[TableName('EntityWithPrivateProperty')]
+class EntityWithPrivateProperty extends BaseEntity
+{
+    #[PrimaryKey]
+    public ?int $id = null;
+
+    #[ColumnType('varchar(255)')]
+    public string $name;
+
+    private string $secret = '';
+
+    public function getSecret(): string {
+        return $this->secret;
+    }
+}

tests/Mock/BaseRepositoryAndBaseEntity/Entities/EntityWithPrivateProperty/PrivatePropertyRepository.php

@@ -0,0 +1,14 @@
+<?php declare(strict_types=1);
+
+namespace Tests\Mock\BaseRepositoryAndBaseEntity\Entities\EntityWithPrivateProperty;
+
+use Zrnik\MkSQL\Updater;
+use Zrnik\MkSQL\Utilities\Installable;
+
+class PrivatePropertyRepository extends Installable
+{
+    protected function install(Updater $updater): void
+    {
+        $updater->use(EntityWithPrivateProperty::class);
+    }
+}