Improved saving strategy

Zrnik · Oct 13, 2021 · f1cca7d · f1cca7d
1 parent 57a46d2
commit f1cca7d
Show file tree

Hide file tree

Showing 3 changed files with 198 additions and 383 deletions.
diff --git a/src/Repository/BaseEntity.php b/src/Repository/BaseEntity.php
@@ -911,11 +911,10 @@ public function setPrimaryKeyValue(mixed $newPrimaryKeyValue): void
     }
 
     /**
-     * @param string[] $savedHashList
      * @return BaseEntity[]
      * @throws ReflectionFailedException
      */
-    public function getSubEntities(array $savedHashList = []): array
+    public function getSubEntities(): array
     {
         $reflection = self::getReflectionClass(static::class);
         $subEntities = [];
@@ -938,16 +937,7 @@ public function getSubEntities(array $savedHashList = []): array
             }
         }
 
-        $allowedSubEntities = [];
-        /** @var BaseEntity $possibleSubEntity */
-        foreach ($subEntities as $possibleSubEntity) {
-            if (!in_array($possibleSubEntity->hash(), $savedHashList, true)) {
-                $allowedSubEntities[] = $possibleSubEntity;
-                $savedHashList[] = $possibleSubEntity->hash();
-            }
-        }
-
-        return $allowedSubEntities;
+        return $subEntities;
     }
 
     public function hash(): string