Silence empty Table test warnings#67
Open
rtlechow wants to merge 1 commit into
Open
Conversation
These bake-generated stub classes had no test methods, so PHPUnit emitted 19 "No tests found in class" warnings. Add a markTestIncomplete placeholder to each, matching the convention used by the other unimplemented Table tests.
rtlechow
marked this pull request as draft
June 23, 2026 21:58
rtlechow
marked this pull request as ready for review
June 24, 2026 16:33
Owner
|
There were previously no tests for the initialize method, so this both adds the tests and then marks them as incomplete. Is that the intent? If so, why is it only adding them for some tables, not all of them? I'm not sure what tests of these functions would accomplish anyway, they'd just assert that static configuration is as expected? I'm not convinced (in general) of the usefulness of such tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
markTestIncomplete('Not implemented yet.')placeholder method tothe 19 bake-generated
*TableTeststub classes that had no test methodswarnings total)
(e.g.
DivisionsTableTest); the warnings now report as incomplete instead