Fixed the backend’s dramatic flair: now invalid payloads get a proper… - #207
Open
datagerl wants to merge 1 commit into
Open
Fixed the backend’s dramatic flair: now invalid payloads get a proper…#207datagerl wants to merge 1 commit into
datagerl wants to merge 1 commit into
Conversation
… meltdown and valid ones get a classy response envelope.”
Cedarich
requested changes
Jul 16, 2026
Cedarich
left a comment
Contributor
There was a problem hiding this comment.
Hi @datagerl, thanks for working on this! I appreciate the effort to standardize request validation and response shapes. However, I noticed a significant architectural conflict:
The Issue:
Your PR adds a new standalone Node.js backend (package.json, server.js, src/app.js, src/validation.js) using the native http module. However, the repository already has an active NestJS TypeScript backend in /veilend-backend that serves as the primary API.
This creates:
- ❌ A duplicate backend that won't be maintained
- ❌ Conflicting response envelopes across the codebase
- ❌ Confusion about which backend to extend or deploy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables shared request validation for backend routes and standardizes the response shape for successful and failed requests.
Valid payloads now return a consistent success envelope with data and metadata.
Invalid payloads now return a predictable error envelope with clear details and error codes.
This improves API consistency and makes client-side handling more reliable.
closes #197