Skip to content

Conversation

Copilot
Copy link

@Copilot Copilot AI commented Sep 24, 2025

The comment in the TransportProtocol enum incorrectly stated that JSON-RPC was "(mandatory)" while gRPC and HTTP+JSON were "(optional)". This contradicted the A2A specification which clearly states that all three transport protocols are equally optional.

According to the specification Section 3.2:

  • Section 3.2.1: "Agents MAY support JSON-RPC 2.0 transport"
  • Section 3.2.2: "Agents MAY support gRPC transport"
  • Section 3.2.3: "Agents MAY support REST-style HTTP+JSON transport"

The specification explicitly states: "All three protocols are considered equal in status, and agents may choose to implement any combination of them based on their requirements."

Before:

export enum TransportProtocol {
  JSONRPC = "JSONRPC", // JSON-RPC 2.0 over HTTP (mandatory)
  GRPC = "GRPC", // gRPC over HTTP/2 (optional)
  HTTP_JSON = "HTTP+JSON", // REST-style HTTP with JSON (optional)
}

After:

export enum TransportProtocol {
  JSONRPC = "JSONRPC", // JSON-RPC 2.0 over HTTP (optional)
  GRPC = "GRPC", // gRPC over HTTP/2 (optional)
  HTTP_JSON = "HTTP+JSON", // REST-style HTTP with JSON (optional)
}

This change ensures the code documentation accurately reflects the specification requirements and prevents confusion for developers implementing A2A-compliant agents.

Fixes #1098.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

- Update comment in TransportProtocol enum to correctly reflect that JSON-RPC is optional
- Aligns with specification Section 3.2.1 which states "Agents MAY support JSON-RPC 2.0 transport"
- All three transport protocols (JSON-RPC, gRPC, HTTP+JSON) are equally optional

Co-authored-by: darrelmiller <[email protected]>
@Copilot Copilot AI changed the title [WIP] [Bug]: Comment indicates JSON-RPC is mandatory, whereas all transports are equally optional Fix TransportProtocol comment: JSON-RPC is optional, not mandatory Sep 24, 2025
@Copilot Copilot AI requested a review from darrelmiller September 24, 2025 02:28
Copilot finished work on behalf of darrelmiller September 24, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Comment indicates JSON-RPC is mandatory, whereas all transports are equally optional
3 participants