Skip to content

refactor: make set_credentials synchronous in InMemoryContextCredentialStore #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
odanilosalve wants to merge 6 commits into
base: main
Choose a base branch
from
Open

refactor: make set_credentials synchronous in InMemoryContextCredentialStore #1116

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7081196
refactor: make set_credentials synchronous in InMemoryContextCredenti…
odanilosalve Jun 28, 2026
1a719ac
Merge pull request #1 from odanilosalve/refactor/remove-async-set-cre…
odanilosalve Jun 28, 2026
5d66d29
refactor: reduce cognitive complexity in AuthInterceptor.before
odanilosalve Jun 28, 2026
f3165a2
fix: resolve SonarQube issues in client transports
odanilosalve Jun 28, 2026
a50b6d1
fix: remove redundant json.JSONDecodeError catch in _handle_http_error
odanilosalve Jun 28, 2026
e33a996
Merge pull request #2 from odanilosalve/refactor/remove-async-set-cre…
odanilosalve Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/a2a/client/auth/credentials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ async def get_credentials(
session_id = context.state['sessionId']
return self._store.get(session_id, {}).get(security_scheme_name)

async def set_credentials(
def set_credentials(
self, session_id: str, security_scheme_name: str, credential: str
) -> None:
"""Method to populate the store."""
Expand Down
8 changes: 4 additions & 4 deletions tests/client/test_auth_interceptor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ async def test_in_memory_context_credential_store(
session_id = 'session-id'
scheme_name = 'test-scheme'
credential = 'test-token'
await store.set_credentials(session_id, scheme_name, credential)
store.set_credentials(session_id, scheme_name, credential)

# Assert: Successful retrieval
context = ClientCallContext(state={'sessionId': session_id})
Expand All @@ -144,7 +144,7 @@ async def test_in_memory_context_credential_store(
assert retrieved_credential_empty is None
# Assert: Overwrite the credential when session_id already exists
new_credential = 'new-token'
await store.set_credentials(session_id, scheme_name, new_credential)
store.set_credentials(session_id, scheme_name, new_credential)
assert await store.get_credentials(scheme_name, context) == new_credential


Expand Down Expand Up @@ -249,7 +249,7 @@ async def test_auth_interceptor_variants(
test_case: AuthTestCase, store: InMemoryContextCredentialStore
) -> None:
"""Parametrized test verifying that AuthInterceptor correctly attaches credentials based on the defined security scheme in the AgentCard."""
await store.set_credentials(
store.set_credentials(
test_case.session_id, test_case.scheme_name, test_case.credential
)
auth_interceptor = AuthInterceptor(credential_service=store)
Expand Down Expand Up @@ -300,7 +300,7 @@ async def test_auth_interceptor_skips_when_scheme_not_in_security_schemes(
scheme_name = 'missing'
session_id = 'session-id'
credential = 'test-token'
await store.set_credentials(session_id, scheme_name, credential)
store.set_credentials(session_id, scheme_name, credential)
auth_interceptor = AuthInterceptor(credential_service=store)
agent_card = AgentCard(
supported_interfaces=[
Expand Down
Loading