Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONFIG: Update GitHub Actions trigger #295

Merged
merged 3 commits into from
Feb 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ on:
pull_request:
branches:
- "*"
push:
branches:
- main
Comment on lines +8 to +9
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this? Probably should only run on tag push, not push to main.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking to use the main push for verifying merged commits.
Otherwise, happy to remove it

tags:
- "v+[0-9]+.[0-9]+.[0-9]*$"

# Cancel in-progress workflow runs on new PR commits.
concurrency:
Expand All @@ -17,9 +22,11 @@ jobs:
steps:
- uses: actions/checkout@v3
- name: Set up Python 3.9.5
uses: actions/setup-python@v3
uses: actions/setup-python@v4
with:
python-version: "3.9.5"
cache: 'pip'
cache-dependency-path: '**/requirements.txt'
- name: Install tox
run: |
# Install tox
Expand All @@ -41,9 +48,11 @@ jobs:
steps:
- uses: actions/checkout@v3
- name: Set up Python 3.9.5
uses: actions/setup-python@v3
uses: actions/setup-python@v4
with:
python-version: "3.9.5"
cache: 'pip'
cache-dependency-path: '**/requirements.txt'
- name: Install tox
run: |
# Install tox
Expand Down
2 changes: 1 addition & 1 deletion surround/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ For more information about Surround library, see [Surround Library](https://surr
## Installation

### Prerequisites
- [Python](https://www.python.org/) 3+ (Tested on 3.6.5)
- [Python](https://www.python.org/) 3.9+ (Tested on 3.9.5)

Use package manager [pip](https://pip.pypa.io/en/stable/) to install the latest (stable) version:
```
Expand Down
Loading