Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negative def decrease dmg #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kjagodka
Copy link

No description provided.

@BLimmie
Copy link

BLimmie commented Aug 2, 2021

Since this only applies to negative numbers, I believe this fix reverses the intended damage calculation. Currently negative defenses close to 0 have damage multipliers slightly greater than 1 [dmg*(2-(1-e))], while large negative defenses have damage multipliers closer to 2 [dmg*(2-e)].

@kjagodka
Copy link
Author

kjagodka commented Aug 2, 2021

Since this only applies to negative numbers, I believe this fix reverses the intended damage calculation. Currently negative defenses close to 0 have damage multipliers slightly greater than 1 [dmg*(2-(1-e))], while large negative defenses have damage multipliers closer to 2 [dmg*(2-e)].

I believe it should be like that. But because in the case of negative defense the fraction (100/(100 + NEGATIVE)) actually gets bigger, as the defense gets more negative, because the denominator approaches 0.
This actually makes damage taken to became negative, when defense is between -50 and -100.

plot on wolfram alpha before change

plot on wolfram alpha after change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants