GCC warning fixes while compiling. #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I know they are only warnings but it's annoying to see a lot of text for ntohing while compiling. JoyHat compiling warning fix - "#import" is obsolete on GCC: - "SDL.h" is not right, changed to "SDL2/SDL.h" Unused parameters: - "int argc, char *args[]" are not used is our case. Deleted until we got an usage to get it back. SDL_Color missing arguments: - added an alpha range value: 255 SDL_rect missing arguments: - added a value that is not even used in the game. JoyHat Initializing Order: - fixed the order for a proper initialization warning fixed Missing initialization: - fixed the missing initialization for BoardScanner::findVerticalMatch() warning fixed Unused variable fixed: - there's no singleton to call here commented code that was not used parseInputEvent(...) waiting a return value: - added a return 0; to bypass the warning it is not like it is waiting for something warning fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know they are only warnings but it's annoying to see a lot of text for ntohing
while compiling.
JoyHat compiling warning fix
Unused parameters:
Deleted until we got an usage to get it back.
SDL_Color missing arguments:
SDL_rect missing arguments:
JoyHat Initializing Order:
warning fixed
Missing initialization:
warning fixed
Unused variable fixed:
commented code that was not used
parseInputEvent(...) waiting a return value:
it is not like it is waiting for something
warning fixed