Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OUI & Ports data #156

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

madmini
Copy link

@madmini madmini commented Sep 6, 2023

Fixes #155.

Wireshark removed the manuf and services files from their git repo which were used for MAC vendor/OUI resolution and port service name and description lookup, respectively. Fortunately, similar replacements are provided elsewhere.

As discussed in #155, Wireshark now hosts a generated file very similar to manuf at https://www.wireshark.org/download/automated/data/manuf.

The services cites the IANA's Service Name and Transport Protocol Port Number Registry as their original source, with permission from and acknowledgement to the IANA.

I have added acknowledgements for both sources to the readme.

Sadly, both replacements do not support Accept-Encoding: gzip, and progress tracking is somewhat broken for the OUI update (finishes when displaying ~33%) and does not work for the ports update.
For this and other reasons, replacements hosted by GitHub or other CDNs would be preferable.

@Coehill
Copy link

Coehill commented Oct 9, 2023

@madmini, You may want to add @aaronjwood as a reviewer.

@madmini
Copy link
Author

madmini commented Oct 9, 2023

@madmini, You may want to add @aaronjwood as a reviewer.

i dont seem to have the permission to do that

@grzwolf
Copy link

grzwolf commented Apr 16, 2024

Pull request commits work perfect. Tested successfully in a local self build, even for SDK 34.
Great job!

Kudos to madmini.

@driehuis
Copy link

For the time being, just replacing master with release-4.0 in app/src/main/java/com/aaronjwood/portauthority/async/DownloadOuisAsyncTask.java makes it work again, which keeps the Github CDN as the source. For now at least, this branch seems to get regular updates, so making that change would buy time until a better source can be arranged.

@lah7 lah7 mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Database 404 error
4 participants