Refactor/dashboard page #2723

AGMASO · 2025-10-20T15:50:03Z

General Changes

Refactored Dashboard using the SDK.
Actions are using the legacy flow for now. All the rest is refactored using SDK

Developer Notes

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

End-to-end tests are passing without any errors
Code changes do not significantly increase the application bundle size
If there are new 3rd-party packages, they do not introduce potential security threats
If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

… sdk

…-page-sdk

vercel · 2025-10-20T15:50:07Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
interface	Ready	Preview	Comment	Dec 8, 2025 1:40pm

github-actions · 2025-12-08T08:13:25Z

Ipfs hash: bafybeibmzswi7m55owbqfokaymktssoz2x6xjracloqmnr32ekd5iuaxli
Ipfs preview link: https://bafybeibmzswi7m55owbqfokaymktssoz2x6xjracloqmnr32ekd5iuaxli.ipfs.cf-ipfs.com/

github-actions · 2025-12-08T08:13:38Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2025-12-08T08:48:18Z

Ipfs hash: bafybeif4aekgxbauguk43gkvsmkxbymbff7ghweb7nikhnvukxkeofuzsm
Ipfs preview link: https://bafybeif4aekgxbauguk43gkvsmkxbymbff7ghweb7nikhnvukxkeofuzsm.ipfs.cf-ipfs.com/

github-actions · 2025-12-08T08:48:26Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2025-12-08T10:57:01Z

Ipfs hash: bafybeibqsb6b5dvgeeldaamk5z6q2b3mjbc4qg3e243e5akweehua5o7vi
Ipfs preview link: https://bafybeibqsb6b5dvgeeldaamk5z6q2b3mjbc4qg3e243e5akweehua5o7vi.ipfs.cf-ipfs.com/

github-actions · 2025-12-08T10:57:20Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mgrabina · 2025-12-09T21:51:56Z

src/hooks/app-data-provider/useUserBorrows.ts

+          },
+        ],
+        user: userAddress!,
+        orderBy: { debt: OrderDirection.Asc },


should we order Desc so bigger first?

it doesn’t sort based on the balance. It sorts according to the internal order in the backend. That’s why I think one ordering or the other makes no difference.

mgrabina · 2025-12-09T21:52:00Z

src/hooks/app-data-provider/useUserSupplies.ts

+          },
+        ],
+        user: userAddress!,
+        orderBy: { balance: OrderDirection.Asc },


should we order Desc so bigger first?

same answer

mgrabina · 2025-12-09T21:53:03Z

src/hooks/useWrappedTokens.tsx

+        symbol: tokenInReserve.underlyingToken.symbol,
+        underlyingAsset: tokenInReserve.underlyingToken.address,
+        decimals: tokenInReserve.underlyingToken.decimals,
+        priceInUSD: tokenInReserve.usdExchangeRate,


is usdExchangeRate giving the amount in usd as we had before or just the rate?

usd amount per token

src/hooks/useWrappedTokens.tsx

mgrabina · 2025-12-09T21:53:34Z

src/modules/dashboard/lists/BorrowAssetsList/BorrowAssetsList.tsx

+  const currentNetworkConfig = useRootStore((store) => store.currentNetworkConfig);
+  const currentMarketData = useRootStore((store) => store.currentMarketData);
+  const currentMarket = useRootStore((store) => store.currentMarket);


can merge these three

mgrabina · 2025-12-09T22:01:52Z

src/modules/dashboard/lists/SuppliedPositionsList/SuppliedPositionsList.tsx

+      0
    );
-  }, [isShowSmallBalanceAssets, user?.userReservesData, marketReferencePriceInUsd]);
+  }, [suppliedPositions]);


we should probably add isShowSmallBalanceAssets (and test the dashboard with some dust)

mgrabina · 2025-12-09T22:02:44Z

src/modules/dashboard/lists/SuppliedPositionsList/SuppliedPositionsListItem.tsx

+  const disableSwap = isPaused || reserve.underlyingToken.symbol == 'stETH';
+  const disableWithdraw = isPaused;
+  const disableSupply = isFrozen || isPaused;


we don't have isActive anymore with the sdk?

src/modules/dashboard/DashboardEModeButton.tsx

mgrabina · 2025-12-09T22:05:08Z

src/modules/umbrella/StakeAssets/UmbrellaAssetsList.tsx

-      //! Your Staked Amount: shows the underlying of assets(ej. USDC, WETH) staked or equivalent to the
-      //! shares.
-      //! Using stakeTokenReedemableAmount should be the equivalent in Asset to the shares


this one seems useful, isnt it?

yeah, I should have only deleted the exclamation. Restored

vercel · 2025-12-11T09:29:53Z

You must have Developer access to commit code to Aave on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles

github-actions · 2025-12-11T09:36:12Z

Ipfs hash: bafybeiasmvez3gbxxffn5k7amzfkjy5evwydofu6sqpcs3ugwprbil4jde
Ipfs preview link: https://bafybeiasmvez3gbxxffn5k7amzfkjy5evwydofu6sqpcs3ugwprbil4jde.ipfs.cf-ipfs.com/

github-actions · 2025-12-11T09:36:21Z

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

AGMASO added 28 commits September 26, 2025 16:05

refactor: sdk integrated in market page

114328f

chore: clean code

940cdf4

fix: simplified icon fetch logic & clean code

fcb1a39

fix: build error

92eeffd

fix: build error

a80c04b

fix: build error

4a5e1fe

chore: clean code

eff6ed6

chore: clean code

8653eb9

refactor: integrate sdk into reserve-overview. missing few flags from…

75769d3

… sdk

fix: show disabled only for > 0 amounts

be28f80

Merge branch 'refactor/sdk-in-markets' into refactor/reserve-overview…

c4d503f

…-page-sdk

fix: solved issue on tokenIcons in reserve-overview page

9f5d624

fix: clean code

47ec420

fix: clean code

18dadae

fix: clean code

27eb9b8

chore: clean code

8f7da60

feat: added interest Rate Strategy Address to link, after updated sdk

2e502e9

fix: use typescript guards

d3d3e45

fix: simplified code

3610842

refactor: move incentives calculation to parent component

4e83b97

chore: clean code

de6b877

Merge branch 'refactor/sdk-in-markets' into refactor/reserve-overview…

cdc1ae9

…-page-sdk

refactor: wip supply assets list finished with sdk

98b4714

refactor: wip supplies positions listo, aun pequenos fallos

9292a2f

refactor: wip your borrows terminado perfecto

9d13c1b

refactor: only dashboard top panel left

59326b7

refactor: only dashboard top panel left

abff5a8

refactor: refactored dashboard with sdk

94b2eb9

feat: added Pts-ethena tokens to mapping

f8fa340

feat: added support for all actions still using legacy flow

4759ef5

vercel bot deployed to Preview December 5, 2025 11:52 View deployment

AGMASO marked this pull request as ready for review December 8, 2025 08:00

Merge branch 'main' into refactor/dashboard-page

0168761

vercel bot deployed to Preview December 8, 2025 08:12 View deployment

fix: i18n rebuild

33ea96b

vercel bot deployed to Preview December 8, 2025 08:44 View deployment

AGMASO added 2 commits December 8, 2025 11:48

fix: corrected some issues hooking data form sdk

5b5e2f6

Merge branch 'main' into refactor/dashboard-page

fbc7f13

vercel bot deployed to Preview December 8, 2025 10:54 View deployment

fix: i18n rebuild

f7bf16b

vercel bot deployed to Preview December 8, 2025 11:12 View deployment

fix: collateral toggle display

857b056

vercel bot deployed to Preview December 8, 2025 13:40 View deployment

mgrabina reviewed Dec 9, 2025

View reviewed changes

fix: address review comments

adfb0c9

AGMASO requested review from JoaquinBattilana, foodaka, grothem and mgrabina December 11, 2025 09:30

chore: clean code

7f59af5

Refactor/dashboard page #2723

Are you sure you want to change the base?

Refactor/dashboard page #2723

Conversation

AGMASO commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

General Changes

Developer Notes

Reviewer Checklist

Uh oh!

vercel bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 8, 2025

Uh oh!

github-actions bot commented Dec 8, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

github-actions bot commented Dec 8, 2025

Uh oh!

github-actions bot commented Dec 8, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

github-actions bot commented Dec 8, 2025

Uh oh!

github-actions bot commented Dec 8, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vercel bot commented Dec 11, 2025

Uh oh!

github-actions bot commented Dec 11, 2025

Uh oh!

github-actions bot commented Dec 11, 2025

📦 Next.js Bundle Analysis for aave-ui

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AGMASO commented Oct 20, 2025 •

edited

Loading

vercel bot commented Oct 20, 2025 •

edited

Loading