Tentative PR from Evan Zhenfeng #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Artem,
I've made changes in following aspects:
function
fixed a #bug# causing realign always to the last domain, rather than to the fittest domain.
identified a error-rasing change in provided
TMalignlink and proposed a new onereplace palmgrab.py subprecess by directly import.
maintainability
added docstring & type-annotation for PalmStructs objects.
replaced file-tree operations with pathlib operators for concision & readability.
slight change in filetree.
robustness
introduced tempfile to handle intermediate files for conflict avoidance (during parallel running).
separated the function to call TMalign for decoupling.