Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(VoiceChannel): Support voice channel statuses #1496

Merged
merged 12 commits into from
Jul 20, 2024
Merged

feat(VoiceChannel): Support voice channel statuses #1496

merged 12 commits into from
Jul 20, 2024

Conversation

conorwastakenwastaken
Copy link
Contributor

@conorwastakenwastaken conorwastakenwastaken commented Apr 21, 2024 •
edited
Loading

Support voice channel statuses

Refs:

Additions:

  • voiceChannelStatusUpdate event
  • Client#setVoiceChannelStatus function
  • VoiceChannel#setStatus function
  • Support setVoiceChannelStatus permission
  • Support VOICE_CHANNEL_STATUS_UPDATE (192) & VOICE_CHANNEL_STATUS_DELETE (193) audit log action types
  • VoiceChannel#status property

@flav-code
Copy link
Contributor

Works fine on my side

  • Edit
  • GuildCreate

@flav-code
Copy link
Contributor

@bsian03

@bsian03
Copy link
Collaborator

bsian03 commented May 1, 2024

I'm aware, I haven't had the chance to look at this yet

@flav-code
Copy link
Contributor

Maybe set the status property to null if not set like the packet sent by discord

@bsian03
Copy link
Collaborator

bsian03 commented Jun 9, 2024

I'm not 100% sure when discord will merge the PRs, so please complete with TS docs so I can preapprove and merge when Discord merge (or when I get impatient, whichever comes first)

@bsian03 bsian03 added the Discord label Jun 9, 2024
@conorwastakenwastaken
Copy link
Contributor Author

I'm not 100% sure when discord will merge the PRs, so please complete with TS docs so I can preapprove and merge when Discord merge (or when I get impatient, whichever comes first)

This PR will be finalised when you let me know what you want me to do with the voiceChannelStatusUpdate event. You told me in dms you'd have a think about it but never got back to me hence it's still a draft 👍🏻

@bsian03
Copy link
Collaborator

bsian03 commented Jun 9, 2024

Ah, sorry. Yeah emit a separate event for it

@conorwastakenwastaken conorwastakenwastaken marked this pull request as ready for review July 11, 2024 16:05
bsian03
bsian03 requested changes Jul 12, 2024
View reviewed changes
lib/Client.js Outdated Show resolved Hide resolved
lib/gateway/Shard.js Outdated Show resolved Hide resolved
@bsian03 bsian03 merged commit a1a449f into abalabahaha:dev Jul 20, 2024
@conorwastakenwastaken conorwastakenwastaken deleted the voicestatus branch July 20, 2024 14:54
Brainicism added a commit to Brainicism/eris that referenced this pull request Jul 26, 2024
@Brainicism
feat(VoiceChannel): Support voice channel statuses (abalabahaha#1496)
8619746
Brainicism added a commit to Brainicism/eris that referenced this pull request Jul 27, 2024
@Brainicism
feat(VoiceChannel): Support voice channel statuses (#15)
a412bb3 
* feat(VoiceChannel): Support voice channel statuses (abalabahaha#1496)

* remove dupe

* remove spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsian03 bsian03 bsian03 approved these changes

Assignees
No one assigned
Labels
Discord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conorwastakenwastaken @flav-code @bsian03