Skip to content

Conversation

rupokify
Copy link

@rupokify rupokify commented Jan 2, 2025

Bengali (bn) language translation was added to the "bn.po" file.

@rupokify
Copy link
Author

rupokify commented Jan 2, 2025

Ready for review.

@abh abh requested a review from Copilot June 5, 2025 22:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces Bengali translations by adding a new bn.po file containing msgid/msgstr entries for UI strings.

  • Adds locale metadata and headers for Bengali (bn)
  • Provides translations for zones, navigation, server templates, and other UI elements
Comments suppressed due to low confidence (3)

i18n/bn.po:100

  • Instead of a literal key with an underscore, use a human-readable Bengali phrase like "ফোরাম বিবরণ" without underscores.
msgstr "ফোরাম_বর্ণনা"

i18n/bn.po:104

  • Replace the underscored key with a readable Bengali phrase such as "খবরের বিবরণ".
msgstr "খবর_বর্ণনা"

i18n/bn.po:108

  • Use a natural Bengali description like "উন্নয়ন তালিকা বিবরণ" instead of the underscored key.
msgstr "উন্নয়ন_তালিকা_বর্ণনা"


#:
msgid "Europe"
msgstr "ইউরোপ"
Copy link
Preview

Copilot AI Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation for "Europe" has an extra hyphenation or misplaced vowel sign. It should be spelled "ইউরোপ" for correct Bengali orthography.

Suggested change
msgstr "ইউরোপ"
msgstr "ইউরোপ"

Copilot uses AI. Check for mistakes.


#:
msgid "Current score: %1 (only servers with a score higher than %2 are used in the pool)"
msgstr "বর্তমান স্কোর: %1 (যেসব সার্ভারের স্কোর %2 এর উপরে শুধুমাত্র সেগুলো পুলে ব‍্যবহার করা হয়)"
Copy link
Preview

Copilot AI Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The transliteration of "score" is spelled "স্কোর"; the more common spelling in Bengali is "স্কোর".

Suggested change
msgstr "বর্তমান স্কোর: %1 (যেসব সার্ভারের স্কোর %2 এর উপরে শুধুমাত্র সেগুলো পুলে ব‍্যবহার করা হয়)"
msgstr "বর্তমান স্কোর: %1 (যেসব সার্ভারের স্কোর %2 এর উপরে শুধুমাত্র সেগুলো পুলে ব‍্যবহার করা হয়)"

Copilot uses AI. Check for mistakes.

@abh
Copy link
Owner

abh commented Jun 5, 2025

@rupokify thank you! We also need to translate the files in docs/ntppool/en/ to the same filenames and structure in docs/ntppool/bn/ for the site translation to work.

@abh abh force-pushed the main branch 3 times, most recently from b215a04 to 1ab7f20 Compare July 25, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants