Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added type annotations #376 #414

Merged
merged 19 commits into from
Aug 11, 2024
Merged

Conversation

abhisheksuran
Copy link

@abhisheksuran abhisheksuran commented Jul 27, 2024

Brief Description

Added type annotations to improve code clarity and enable static type checking.

Requirements / Checklist

Related Issue

#376

Context

This change addresses issue #376 by adding type annotations.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Screenshots (if available):

None

Copy link

welcome bot commented Jul 27, 2024

Thanks so much for opening your first PR here, a maintainer will get back to you shortly!

In the meantime:

Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.04%. Comparing base (bba3211) to head (3111d2c).

Additional details and impacted files
@@             Coverage Diff             @@
##           testing     #414      +/-   ##
===========================================
- Coverage    93.40%   92.04%   -1.37%     
===========================================
  Files           15       15              
  Lines         3080     3105      +25     
===========================================
- Hits          2877     2858      -19     
- Misses         203      247      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhiTronix abhiTronix self-requested a review July 27, 2024 12:47
@abhiTronix abhiTronix added ENHANCEMENT ⚡ New Feature/Addition/Improvement PENDING TESTS 🧪 Waiting for CI tests to complete successfully. WORK IN PROGRESS 🚧 currently been worked on. labels Jul 27, 2024
@abhiTronix abhiTronix added this to the v0.3.4 milestone Jul 27, 2024
Copy link
Owner

@abhiTronix abhiTronix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 !

@abhiTronix abhiTronix linked an issue Jul 27, 2024 that may be closed by this pull request
4 tasks
@abhiTronix
Copy link
Owner

abhiTronix commented Jul 27, 2024

@abhisheksuran You can proceed with next file, maybe pigear.py. Makes sure to push commit in this same PR. Goodluck!

@abhiTronix abhiTronix self-requested a review July 28, 2024 12:54
@abhiTronix abhiTronix added the META 💭 Meta Issue/PR label Aug 9, 2024
@abhiTronix abhiTronix merged commit 31550b6 into abhiTronix:testing Aug 11, 2024
11 checks passed
Copy link

welcome bot commented Aug 11, 2024

Congrats on merging your first pull request here! 🎉 You're awesome!
Alt Text

@abhiTronix abhiTronix added SOLVED 🏁 This issue/PR is resolved now. Goal Achieved! and removed WORK IN PROGRESS 🚧 currently been worked on. PENDING TESTS 🧪 Waiting for CI tests to complete successfully. labels Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENHANCEMENT ⚡ New Feature/Addition/Improvement META 💭 Meta Issue/PR SOLVED 🏁 This issue/PR is resolved now. Goal Achieved!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal]: Add type annotations to the code or add stub files
2 participants