feat(mcp): normalize impact and context parameter aliases

[100yenadmin]

Summary

• accept impact.target, impact.name, and impact.symbol
• accept context.file_path and context.file
• reject conflicting canonical and alias values before repository resolution
• normalize once before single-repository or group dispatch

Validation

• tsc --noEmit on current upstream
• vitest run test/unit/tools.test.ts (32 passing)
• vitest run test/unit/calltool-dispatch.test.ts (216 passing)
• vitest run test/integration/local-backend-calltool.test.ts (34 passing against LadybugDB)
• focused Prettier and diff checks

The older stacked fork PR had one unrelated typecheck job fail because its historical base lockfile omitted @huggingface/transformers; all runtime and platform jobs passed. This branch starts from current upstream and passes a clean local typecheck. Its own current-head CI is the remote acceptance gate.

Closes #2461

[vercel]

Someone is attempting to deploy a commit to the NexusCore Team on Vercel.

A member of the Team first needs to authorize it.

[100yenadmin]

Self-review follow-up at 3f3494fd:

• rebased behavior onto current upstream main via a normal merge (no history rewrite)
• removed the advertised top-level anyOf, which some MCP providers reject
• moved the at-least-one impact target contract into runtime normalization
• preserved valid target_uid-only impact calls
• reject empty, non-string, and conflicting aliases before repository resolution
• retain canonicalization before group forwarding

Focused proof: 287 dispatch/schema/real-index tests pass; typecheck and Prettier pass; ESLint reports zero errors (repository baseline warnings remain).

[100yenadmin]

The current-head CI failures exposed an internal CLI compatibility case that the MCP-only tests did not cover: Commander materializes omitted optional flags as properties whose value is JavaScript undefined. Alias normalization treated those as explicitly supplied invalid values, so ordinary context CLI calls returned a validation error before repository resolution.

Fixed at d4576630: undefined optional alias keys are now treated as absent. Explicit nulls, non-strings, blanks, and conflicts still fail closed.

Focused proof:

• 289 alias schema, dispatch, and real-index tests
• exact previously failing cli-limit-e2e and skip-git-cli suites: 23/23 pass
• build and npx tsc --noEmit
• focused Prettier and ESLint: zero errors (pre-existing warning baseline only)

GitHub CI has restarted on the repaired exact head.

[github-actions]

CI Report

✅ All checks passed

Pipeline Status

Stage	Status	Details
✅ Typecheck	success	tsc --noEmit
✅ Tests	success	unit tests, 3 platforms
✅ E2E	success	gitnexus-web changes only

Test Results

Tests	Passed	Failed	Skipped	Duration
14553	14491	0	62	18s

✅ All 14491 tests passed

62 test(s) skipped — expand for details

• PreToolUse augmentation filtering (integration) > CJS: emits the MCP-query hint on stdout, stderr silent by default, when a GitNexus MCP process owns the repo DB
• PreToolUse augmentation filtering (integration) > CJS: MCP-owner path emits the MCP query hint; stderr reason gated by GITNEXUS_DEBUG
• PreToolUse augmentation filtering (integration) > CJS: MCP-owner hint emits on stdout; stderr stays silent with GITNEXUS_DEBUG='0'
• PreToolUse augmentation filtering (integration) > CJS: MCP-owner hint emits on stdout; stderr stays silent with GITNEXUS_DEBUG='false'
• PreToolUse augmentation filtering (integration) > Plugin: emits the MCP-query hint on stdout, stderr silent by default, when a GitNexus MCP process owns the repo DB
• PreToolUse augmentation filtering (integration) > Plugin: MCP-owner path emits the MCP query hint; stderr reason gated by GITNEXUS_DEBUG
• PreToolUse augmentation filtering (integration) > Plugin: MCP-owner hint emits on stdout; stderr stays silent with GITNEXUS_DEBUG='0'
• PreToolUse augmentation filtering (integration) > Plugin: MCP-owner hint emits on stdout; stderr stays silent with GITNEXUS_DEBUG='false'
• MCP-owner hint throttle (PreToolUse hook silently skips when MCP server owns DB lock — defeats the purpose #2396) > CJS: emits once, then throttles within the window (marker gates it)
• MCP-owner hint throttle (PreToolUse hook silently skips when MCP server owns DB lock — defeats the purpose #2396) > Plugin: emits once, then throttles within the window (marker gates it)
• MCP hint pattern escaping (PreToolUse hook silently skips when MCP server owns DB lock — defeats the purpose #2396) > CJS: quote+newline pattern stays JSON-safe in additionalContext
• MCP hint pattern escaping (PreToolUse hook silently skips when MCP server owns DB lock — defeats the purpose #2396) > Plugin: quote+newline pattern stays JSON-safe in additionalContext
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > CJS: skips augment for real node_modules/gitnexus ps line (npx child)
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > CJS: npx parent command line is NOT treated as GitNexus server owner
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > CJS: skips augment for gitnexus serve child
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > CJS: ENOENT lsof → augment still runs (fail-open)
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > CJS: ETIMEDOUT lsof → augment skipped (fail-closed)
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > CJS: ETIMEDOUT lsof → emits hint on stdout, stderr silent by default
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > CJS: ETIMEDOUT lsof with wrapper disabled → identical fail-closed skip
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > CJS: bad wrapper (no -k support) is rejected by the self-test → still fail-closed
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > CJS: guard exit 124 (budget expiry) → fail-closed skip
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > CJS: guard signal-death (status null + signal, no error) → fail-closed skip
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > CJS: always-exit-0 stub guard is rejected → augment still runs and emits context
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > CJS: non-GitNexus ps line → augment runs
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > CJS: multiple PIDs — skip if any ps line is GitNexus MCP
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > CJS: ps ENOENT → augment runs (ignore that PID)
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > Plugin: skips augment for real node_modules/gitnexus ps line (npx child)
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > Plugin: npx parent command line is NOT treated as GitNexus server owner
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > Plugin: skips augment for gitnexus serve child
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > Plugin: ENOENT lsof → augment still runs (fail-open)
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > Plugin: ETIMEDOUT lsof → augment skipped (fail-closed)
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > Plugin: ETIMEDOUT lsof → emits hint on stdout, stderr silent by default
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > Plugin: ETIMEDOUT lsof with wrapper disabled → identical fail-closed skip
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > Plugin: bad wrapper (no -k support) is rejected by the self-test → still fail-closed
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > Plugin: guard exit 124 (budget expiry) → fail-closed skip
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > Plugin: guard signal-death (status null + signal, no error) → fail-closed skip
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > Plugin: always-exit-0 stub guard is rejected → augment still runs and emits context
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > Plugin: non-GitNexus ps line → augment runs
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > Plugin: multiple PIDs — skip if any ps line is GitNexus MCP
• Ladybug DB owner guard — production-shaped ps + failure modes (fix: skip Claude augment hook when GitNexus server owns DB #1493) > Plugin: ps ENOENT → augment runs (ignore that PID)
• Ruby pipeline benchmark > scales with file count (workers enabled)
• Rust pipeline benchmark > scales with file count (workers enabled)
• C++ capture identifier-type-lookup benchmark > capture emit scales sub-quadratically with co-scaled enums and call sites
• run.cjs direct-exec entrypoint (fix(cli): steer docs, skills, and hooks through a CLI-neutral project-local runner (#1939) #1945) > resolves a .cmd shim via the Windows shell branch, passing args and exit code
• buildTypeEnv > known limitations (documented skip tests) > Ruby block parameter: users.each { |user| } — closure param inference, different feature
• antigravity hook adapter e2e > AfterTool — MCP-query hint when MCP server owns the DB (PreToolUse hook silently skips when MCP server owns DB lock — defeats the purpose #2396) > emits the MCP-query hint on stdout, no stderr noise, exit 0 (CLI augment never ran)
• antigravity hook adapter e2e > AfterTool — MCP-query hint when MCP server owns the DB (PreToolUse hook silently skips when MCP server owns DB lock — defeats the purpose #2396) > surfaces the skip reason on stderr only under GITNEXUS_DEBUG=1
• C# pipeline benchmark > scales with file count — namespaces spread across the solution
• C# pipeline benchmark > scales with file count — all types in one (global) namespace bucket
• C# pipeline benchmark > scales with file count — all types in one (named) namespace bucket
• COBOL pipeline benchmark > scales with file count
• C++ ADL emit benchmark > emit phase scales sub-quadratically with co-scaled files and sites
• PHP pipeline benchmark > scales with file count (workers enabled)
• getOsPageSize > returns undefined on Windows without forking
• Go pipeline benchmark > scales with file count (workers enabled)
• Go pipeline benchmark — worker pool (issue Worker idle timeout kills long Go scope extraction and surfaces as Napi::Error during analyze #1848) > does not quarantine the large generated Go file on sub-batch idle timeout
• Go structural interface detection benchmark > scales linearly with interface × struct count
• Go structural interface detection split-phase benchmark > separates index-build and detection time
• Spring inheritance scaling benchmark (Spring route extraction: ingestion does not resolve interface-inherited mappings (#2280) #2288) > scales linearly with interface×controller pair count
• Spring inheritance pipeline benchmark — end-to-end (Spring route extraction: ingestion does not resolve interface-inherited mappings (#2280) #2288) > full analyze scales linearly with interface→controller pair count
• C++ pipeline benchmark > scales with file count
• Vue pipeline benchmark > scales with component count

Code Coverage

Tests

Metric	Coverage	Covered	Base	Delta	Status
Statements	80.69%	53938/66839	80.68%	📈 +0.0	🟢 ████████████████░░░░
Branches	67.71%	32928/48624	67.7%	📈 +0.0	🟢 █████████████░░░░░░░
Functions	86.72%	6214/7165	86.72%	＝ 0.0	🟢 █████████████████░░░
Lines	84.22%	48110/57122	84.21%	📈 +0.0	🟢 ████████████████░░░░

---

_{📋 View full run · Generated by CI}

[magyargergo]

The normalizer sits at the right chokepoint, after the group early return but before repo routing, and the test proving groupImpact receives the canonical target is exactly the coverage I wanted. Good catch on the Commander undefined flags regression, that chokepoint touches every CLI command and the dedicated test locks it in.

One design question and one behavior note inline. Merge order: conflicts with #2460 on tools.ts, whoever lands second rebases.

[magyargergo]

Merged via #2511. I kept the runtime guard over anyOf; #2489 proposing to drop the api_impact combinator supports that call from the other direction.