Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/signing algorithms #67

Merged

Conversation

chadgates
Copy link
Contributor

#60

@chadgates
Copy link
Contributor Author

This is first PR of series. Will add next ones when this on is merged.

@@ -28,3 +28,7 @@
"aes_192_cbc",
"aes_256_cbc",
)
SIGNATUR_ALGORITHMS = (
"rsassa_pkcs1v15",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did the original issue not want support for non rsa algos?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, but the ticket has actually two parts, I only tackled the part that signature algo cannot be passed down, because it is missed in the partner object.

I miss the information about which other algos we should implement. I do think we can keep ticket as such open and ask that question and make another feature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhishek-ram : good to go or ?

@abhishek-ram abhishek-ram merged commit 499fd03 into abhishek-ram:master May 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants