-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example apps testflight continuous delivery #483
Draft
JakubJankowski
wants to merge
15
commits into
main
Choose a base branch
from
example-apps-testflight-continuous-delivery
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds to TestFlight via Fastlane
…oad_to_testflight` lane.
JakubJankowski
force-pushed
the
example-apps-testflight-continuous-delivery
branch
8 times, most recently
from
December 5, 2022 11:44
33516ab
to
2c357fd
Compare
JakubJankowski
force-pushed
the
example-apps-testflight-continuous-delivery
branch
2 times, most recently
from
December 5, 2022 13:30
14f082e
to
cb794f4
Compare
JakubJankowski
force-pushed
the
example-apps-testflight-continuous-delivery
branch
9 times, most recently
from
December 5, 2022 22:07
bc82338
to
ad18e13
Compare
JakubJankowski
force-pushed
the
example-apps-testflight-continuous-delivery
branch
from
December 7, 2022 10:19
8b0af7d
to
2c16f8b
Compare
JakubJankowski
force-pushed
the
example-apps-testflight-continuous-delivery
branch
from
December 7, 2022 10:37
2c16f8b
to
3dd9617
Compare
JakubJankowski
force-pushed
the
example-apps-testflight-continuous-delivery
branch
2 times, most recently
from
December 7, 2022 11:52
0d49556
to
1b43e26
Compare
JakubJankowski
force-pushed
the
example-apps-testflight-continuous-delivery
branch
from
December 7, 2022 12:14
1b43e26
to
213914b
Compare
JakubJankowski
force-pushed
the
example-apps-testflight-continuous-delivery
branch
from
December 8, 2022 12:17
c7c4a0e
to
fce1272
Compare
…me minor improvements to the SubscriberExample's Fastfile
JakubJankowski
force-pushed
the
example-apps-testflight-continuous-delivery
branch
from
December 8, 2022 14:21
fce1272
to
380453e
Compare
JakubJankowski
force-pushed
the
example-apps-testflight-continuous-delivery
branch
from
December 12, 2022 09:10
270f64f
to
ffc7de2
Compare
JakubJankowski
force-pushed
the
example-apps-testflight-continuous-delivery
branch
from
December 12, 2022 14:24
f56a9e1
to
c1f684e
Compare
…ly create the amplifyConfiguration.json file from the ENV
JakubJankowski
force-pushed
the
example-apps-testflight-continuous-delivery
branch
from
December 12, 2022 14:29
c1f684e
to
58b53f6
Compare
@QuintinWillison as mentioned in standup, I'm assigning this one to you until the Apple ID is set up. Please assign to me afterwards, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case I won't be able to finish work on this PR before my holidays here is what needs to be done for this PR to be ready for review:
We're mainly waiting for the IT team to create an App Store Connect user that we will use to auth with App Store Connect in the
upload_to_testflight
step in two Fastfiles: both for the PublisherExampleSwiftUI and Subscriber Example apps.APPLE_APPS_USERNAME
, which will contain the email of the App Store Connect userAPPLE_APPS_APPLICATION_SPECIFIC_PASSWORD
with this password. Inn testflight.yml We make aFASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD
ENV from it, which is automatically detected and used by Fastlane during theupload_to_testflight
step.testflight.yml
is set to run onpull_request:
for testing purposes. Once this whole flow is finally tested and it works fine, it should be set to run only when code is pushed to themain
branch, sopull_request:
bit needs to be removed.Additional considerations:
AMPLIFY_CONFIGURATION
secret added (used intestflight.yml
). I've used it in a similar way as it's used in theassemble.yml
workflow, but that workflow doesn't even create a JSON file or use this created ENV in any way. So we need to double check if everything is fine here.