Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher example: Add a setting for logging LocationHistoryData JSON #517

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

lawrence-forooghian
Copy link
Collaborator

@lawrence-forooghian lawrence-forooghian commented Dec 15, 2022

While testing a fix for #425, I wanted to have access to the location history data in a log message.

This adds a switch in a new "Developer settings" section of the Settings page, which when turned on will emit a JSON serialization of the location history data when it’s received from the SDK. It’s turned off by default, because it's only for my specific use case.

@lawrence-forooghian lawrence-forooghian changed the title Publisher example: Add a setting for logging LocationHistoryData JSON Publisher example: Add a setting for logging LocationHistoryData JSON Dec 15, 2022
@github-actions github-actions bot temporarily deployed to staging/pull/517/jazzy December 15, 2022 19:49 Inactive
@lawrence-forooghian lawrence-forooghian marked this pull request as ready for review December 15, 2022 20:12
Copy link
Contributor

@ikbalkaya ikbalkaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot temporarily deployed to staging/pull/517/jazzy December 19, 2022 11:49 Inactive
While testing a fix for #425, I wanted to have access to the location
history data in a log message.

This adds a switch in a new "Developer settings" section of the Settings
page, which when turned on will emit a JSON serialization of the
location history data when it’s received from the SDK. It’s turned off
by default, because it's only for my specific use case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants