Refactored code as per review comments

ably · Dec 1, 2023 · d2cc0cf · d2cc0cf
1 parent 5865513
commit d2cc0cf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/ably/proto_protocol_message_test.go b/ably/proto_protocol_message_test.go
@@ -23,7 +23,7 @@ func TestProtocolMessageEncodeZeroSerials(t *testing.T) {
 	}
 	encoded, err := ablyutil.MarshalMsgpack(msg)
 	assert.NoError(t, err)
-	// expect a 3-element map with both the serial fields set to zero
+	// expect a 2-element map with both the serial fields set to zero
 	expected := []byte("\x82\xa2id\xa4test\xa9msgSerial\x00")
 	assert.True(t, bytes.Equal(encoded, expected),
 		"unexpected msgpack encoding\nexpected: %x\nactual:   %x", expected, encoded)

diff --git a/ably/realtime_channel.go b/ably/realtime_channel.go
@@ -547,7 +547,7 @@ func (c *RealtimeChannel) SubscribeAll(ctx context.Context, handle func(*Message
 	return unsubscribe, nil
 }
 
-// SubscribeAll registers an event listener for error messages on this channel.
+// OnError registers an event listener for error messages on this channel.
 //
 // See package-level documentation => [ably] Event Emitters for details about messages dispatch.
 func (c *RealtimeChannel) OnError(handle func(*ErrorInfo)) (func(), error) {