Set env variable to be job level instead of global

ably · Jul 23, 2024 · e6177a4 · e6177a4
1 parent 3e2f1c7
commit e6177a4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -1,8 +1,5 @@
 # Based upon:
 #   https://github.com/actions/starter-workflows/blob/main/ci/go.yml
-env:
-  HTTP_PROXY: http://ably:[email protected]:7128
-  HTTPS_PROXY: https://ably:[email protected]:7128
 
 on:
   pull_request:
@@ -45,6 +42,9 @@ jobs:
         run: go install github.com/jstemmer/go-junit-report@latest
 
       - name: Unit Tests
+        env:
+          HTTP_PROXY: http://ably:[email protected]:7128
+          HTTPS_PROXY: https://ably:[email protected]:7128
         run: |
           set -o pipefail
           echo "proxy is $HTTP_PROXY"

diff --git a/.github/workflows/integration-test.yml b/.github/workflows/integration-test.yml
@@ -1,7 +1,3 @@
-env:
-  HTTP_PROXY: http://ably:[email protected]:7128
-  HTTPS_PROXY: https://ably:[email protected]:7128
-
 on:
   pull_request:
   push:
@@ -35,6 +31,9 @@ jobs:
         run: go install github.com/jstemmer/go-junit-report@latest
 
       - name: Integration Tests with ${{ matrix.protocol }} Protocol
+        env:
+          HTTP_PROXY: http://ably:[email protected]:7128
+          HTTPS_PROXY: https://ably:[email protected]:7128
         run: |
           echo "proxy is $HTTP_PROXY"
           set -o pipefail