Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/host fallback conditions #629

Merged
merged 10 commits into from
Jan 19, 2024
Merged

Fix/host fallback conditions #629

merged 10 commits into from
Jan 19, 2024

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Jan 19, 2024

@github-actions github-actions bot temporarily deployed to staging/pull/629/features January 19, 2024 10:59 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/629/godoc January 19, 2024 10:59 Inactive
@sacOO7 sacOO7 requested a review from ttypic January 19, 2024 11:02
ttypic
ttypic approved these changes Jan 19, 2024
View reviewed changes
Copy link

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot temporarily deployed to staging/pull/629/features January 19, 2024 11:15 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/629/godoc January 19, 2024 11:15 Inactive
@sacOO7 sacOO7 force-pushed the fix/host-fallback-conditions branch from 1513563 to 6531b04 Compare January 19, 2024 11:24
@github-actions github-actions bot temporarily deployed to staging/pull/629/features January 19, 2024 11:24 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/629/godoc January 19, 2024 11:24 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/629/features January 19, 2024 12:22 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/629/godoc January 19, 2024 12:22 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/629/features January 19, 2024 14:29 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/629/godoc January 19, 2024 14:29 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/629/features January 19, 2024 15:16 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/629/godoc January 19, 2024 15:17 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/629/features January 19, 2024 15:41 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/629/godoc January 19, 2024 15:42 Inactive
@sacOO7 sacOO7 force-pushed the fix/host-fallback-conditions branch from a024bb4 to 9619657 Compare January 19, 2024 15:44
@github-actions github-actions bot temporarily deployed to staging/pull/629/features January 19, 2024 15:45 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/629/godoc January 19, 2024 15:45 Inactive
@sacOO7 sacOO7 force-pushed the fix/host-fallback-conditions branch from 9619657 to e43bb34 Compare January 19, 2024 16:49
@sacOO7 sacOO7 merged commit 81e8b29 into main Jan 19, 2024
8 checks passed
@sacOO7 sacOO7 deleted the fix/host-fallback-conditions branch January 19, 2024 17:15
@sacOO7 sacOO7 self-assigned this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttypic ttypic ttypic approved these changes

Assignees

@sacOO7 sacOO7

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ably-go doesn't retry requests to fallback hosts on a timeout
2 participants
@sacOO7 @ttypic